Restore Examples revised to IFC4.3RC3#84
Open
jmirtsch wants to merge 1 commit intobSI-InfraRoom:developfrom
Open
Restore Examples revised to IFC4.3RC3#84jmirtsch wants to merge 1 commit intobSI-InfraRoom:developfrom
jmirtsch wants to merge 1 commit intobSI-InfraRoom:developfrom
Conversation
Member
|
Before I start reviewing these files, I'd propose to wait for RC4 and I'll try and run them through TUM OpenInfraPlatform with a script. I can then check against the screen shots from 4x1 version of the standard and prove:
I cant vouch for other content, though. What do you think? |
Collaborator
|
Maybe could run the IfcKit over this also. I will postpone this a bit then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples were disabled during Release Candidate publishing. They were not compliant with recent versions of IFC.
I've revised them according to IFC4.3RC3 and validated them with the KIT checker.
Alignment examples (and other infrastructure examples) will need to be revised in a separate task.