Skip to content

Update IfcCourse documentation#579

Open
larswik wants to merge 7 commits intobSI-InfraRoom:tunnelfrom
larswik:feature/IfcCourse-documentation-NOTE
Open

Update IfcCourse documentation#579
larswik wants to merge 7 commits intobSI-InfraRoom:tunnelfrom
larswik:feature/IfcCourse-documentation-NOTE

Conversation

@larswik
Copy link
Collaborator

@larswik larswik commented Apr 20, 2023

Fixes #578

@larswik larswik requested a review from SergejMuhic April 20, 2023 09:12
@pjanck pjanck linked an issue Apr 21, 2023 that may be closed by this pull request
Copy link
Collaborator

@SergejMuhic SergejMuhic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting.

larswik and others added 6 commits May 2, 2023 09:14
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
…nfrastructureElements/Entities/IfcCourse/Documentation.md

Co-authored-by: SergejMuhic <sergejs1@gmail.com>
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend ordering the values alphabetically (e.g. AnticrackingLayer is way down as it should be).

- **RegulatingCourse** : Type of Course, layer of variable thickness for adjusting a surface so meet specified even level. Also: Levelling course.
>NOTE Definition according to PIARC: Course of variable thickness applied to an existing course or surface to provide the necessary profile for a further course of constant thickness (CEN).
- **Sealing** : A layer of impermeable material.
- **SubBaseCourse** : A layer between subgrade and base course.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseCourse exists in the list, SubgradeCourse doesn't. Intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseCourse exists in the list, SubgradeCourse doesn't. Intentional?

If you with subgrade course mean subgrade, then I believe this is part of IfcEarthworksFill. See https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/ifcearthworksfilltypeenum.htm

@SergejMuhic
Copy link
Collaborator

Somehow it seems that not all changes were committed. Can this be or is it a github fluke?

Also, @pjanck comment is still open. Can we resolve it?

@larswik
Copy link
Collaborator Author

larswik commented Jun 30, 2023

I would recommend ordering the values alphabetically (e.g. AnticrackingLayer is way down as it should be).

I can agree with your comment. However, this is the text we got from the IFC Road stakeholders (including Karin). Do you think that this is really necessary?

@SergejMuhic
Copy link
Collaborator

Since this was not merged into 4.3, what do we want to do with it?

@pjanck pjanck added BucketB Generic 4-T content BucketA Content 4.3.2.0 or older and removed BucketB Generic 4-T content labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BucketA Content 4.3.2.0 or older

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing NOTE to description of IfcCourse

3 participants

Comments