refactor: unify request errors + add audit log middleware#327
Closed
Destynova2 wants to merge 5 commits intomainfrom
Closed
refactor: unify request errors + add audit log middleware#327Destynova2 wants to merge 5 commits intomainfrom
Destynova2 wants to merge 5 commits intomainfrom
Conversation
CI re-runs the full test suite (incl. doctests) on every PR via the .github/workflows/ci.yml tests job, so local pre-push duplication adds ~20 min per push without catching anything new. Pre-push hooks should be fast-fail; expensive checks belong on the CI server. Closes audit finding: silent productivity tax (pre-push duplication).
Documents the three-state intent (true/false/absent) of ProviderConfig.is_enabled and the dependency on deny_unknown_fields (added in the next commit) to reject typos like enbaled = false at parse time. Behaviour is unchanged; this is purely contractual clarity to support the silent-typo-killer audit. Closes audit finding: silent typo killer on provider config.
Adds #[serde(deny_unknown_fields)] to AppConfig and the major sub-structs (ProviderConfig, ModelConfig, TierConfig, RouterConfig, ScoringConfig, CacheConfig, BudgetConfig, DlpConfig, SecurityConfig). Without this guard, a typo like enbaled = false in a [[providers]] block silently parses (the unknown key is dropped) and the provider remains enabled with the wrong intent. With the guard, parsing fails loudly and the operator gets an actionable error pointing at the offending key. Tested with the full nextest suite (1268 tests) plus all doctests: no fixture, preset or example carries a stale field, so this is a pure tightening with no migration cost. Closes audit finding: silent typo killer on TOML config.
Each entry in DENIED_SECTIONS / DENIED_KEYS now carries a short justification table covering why it can not be hot-reloaded — either because the data is sensitive (credentials, DLP rules) or because the consumer is constructed once at process start (TLS listener, secret backend, TEE attestation, FIPS gate). Adds tee, fips, server.tls and secrets.backend to the deny-list so the documented "static-init" rationale matches actual behaviour. Also emits an INFO log on every denied attempt telling the operator to restart instead of expecting the silent reload to apply. Adds two unit tests covering the new deny entries (tee/fips sections and server.tls / secrets.backend keys) and asserts that sibling keys in the same sections remain editable. Closes audit finding: hot-reload UX (silent ignore of denied edits).
Replaces the `AppError` + `ProviderError` split with a single `RequestError` enum that carries the upstream HTTP status verbatim (502/503/504) instead of flattening every provider failure to a generic 502 body. Introduces the canonical `RequestError::is_retryable` classifier as the single source of truth for retry/backoff decisions and removes three duplicate 429 detectors from `dispatch/retry.rs`. Also adds an Axum audit-log middleware (`audit_log_layer`) that emits an `AuditEvent::RequestProcessed` entry for every request lifecycle — including OAuth, config, and error paths that previously bypassed audit entirely. Uses an `AuditedAlready` response-extension marker so the dispatch path (which writes a richer DLP/risk/token-aware entry) is not double-logged. Closes the audit gap that allowed silent model enumeration via DLP probes (EU AI Act Article 6 / PCI DSS 3.4). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by a clean rebased version targeting current main. The original branch was based on a stale fix/preset-mod-include-str ancestor; the new PR rebases cleanly onto main and removes the unintended diff regressions. |
auto-merge was automatically disabled
April 28, 2026 21:04
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppError+ProviderErrorsplit with a singleRequestErrorenum that carries the upstream HTTP status verbatim (502/503/504) instead of flattening every provider failure to a generic 502 body. New variants:BadRequest,Unauthorized,Forbidden,NotFound,ParseError,RoutingError,RateLimited{provider, retry_after_ms},ProviderUpstream{provider, status, body},BudgetExceeded{limit_usd, actual_usd},DlpBlocked,AuthRevoked,Internal(anyhow::Error).RequestError::is_retryable()is the canonical retry classifier — removes three duplicate 429 detectors fromdispatch/retry.rsand centralises the matcher.audit_log_layer) that emitsAuditEvent::RequestProcessedfor every request — including OAuth, config, and error paths that previously bypassed audit entirely. De-dupes via theAuditedAlreadyresponse-extension marker so the dispatch pipeline (which writes a richer DLP/risk/token-aware entry) is the single source of truth on the hot path. Closes the audit gap that allowed silent model enumeration via DLP probes (EU AI Act Article 6 / PCI DSS 3.4).Test plan
cargo check(default features, all features, no-default-features)cargo clippy --tests --all-targets -- -D warningscargo fmt --checkcargo nextest run— 1309/1309 tests passRequestError::IntoResponseandis_retryable()covering every variant🤖 Generated with Claude Code