Skip to content

Fix args passed to rasterio.transform.from_origin() in write_bbox()#2316

Merged
AdeelH merged 1 commit intoazavea:masterfrom
AdeelH:bug-fix
Feb 21, 2025
Merged

Fix args passed to rasterio.transform.from_origin() in write_bbox()#2316
AdeelH merged 1 commit intoazavea:masterfrom
AdeelH:bug-fix

Conversation

@AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Feb 21, 2025

Overview

This PR fixes a bug in write_bbox() where the horizontal and vertical components of the resolution were being passed in the wrong order to rasterio.transform.from_origin(). This wasn't caught before because the unit test for write_bbox() used square arrays; this test has now been updated to use rectangular arrays.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

See updated unit tests.

@AdeelH AdeelH merged commit b2b85db into azavea:master Feb 21, 2025
2 checks passed
@AdeelH AdeelH deleted the bug-fix branch February 21, 2025 17:43
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (9c896e9) to head (690deab).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2316   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         199      199           
  Lines        9999     9999           
=======================================
  Hits         9038     9038           
  Misses        961      961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant