Fix args passed to rasterio.transform.from_origin() in write_bbox()#2316
Merged
AdeelH merged 1 commit intoazavea:masterfrom Feb 21, 2025
Merged
Fix args passed to rasterio.transform.from_origin() in write_bbox()#2316AdeelH merged 1 commit intoazavea:masterfrom
rasterio.transform.from_origin() in write_bbox()#2316AdeelH merged 1 commit intoazavea:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2316 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 199 199
Lines 9999 9999
=======================================
Hits 9038 9038
Misses 961 961 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in
write_bbox()where the horizontal and vertical components of the resolution were being passed in the wrong order torasterio.transform.from_origin(). This wasn't caught before because the unit test forwrite_bbox()used square arrays; this test has now been updated to use rectangular arrays.Checklist
needs-backportlabel if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
See updated unit tests.