ci: fix snap push-metadata (drop --from-yaml, removed in snapcraft 8.x)#27
Merged
Conversation
snapcraft 8.x removed the --from-yaml flag. Metadata is now read from the .snap file's embedded yaml. Both push-metadata sites (the one-shot manual workflow and the publish-snap step in release.yml) need to: 1. Build a fresh snap first (so the new snap/snapcraft.yaml is embedded) 2. Call snapcraft push-metadata <snap-file> --force (no --from-yaml) For the manual workflow this means swapping the 'snap download' step for snapcore/action-build@v1 — slower (~15 min LXD build) but correct. For release.yml the build is already happening for the publish step, so only the flag change is needed. Reproducer: the snap-push-metadata workflow run dispatched after PR #26 failed with 'Error: No such option: --from-yaml'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snap-push-metadata workflow dispatched after PR #26 failed:
```
Error: No such option: --from-yaml
```
snapcraft 8.x dropped --from-yaml. Metadata is now read from the .snap file's embedded yaml. So we need to:
This PR:
After merge: `gh workflow run snap-push-metadata.yml` to dispatch the corrected one-shot.