fix: stop table scroll wheel nudging#23
Merged
Merged
Conversation
Remove vertical-wheel forwarding from wide table scroll areas so page scrolling no longer shifts tables sideways, while preserving horizontal access through the table scrollbar/native horizontal input. Co-Authored-By: OpenClaude (gpt-5.5) <openclaude@gitlawb.com>
6 tasks
aydiler
added a commit
that referenced
this pull request
May 24, 2026
Restores the wheel-to-x table-scroll ergonomic from issue #4 but gates it on the Shift modifier, so plain wheel still scrolls the document (#22) while Shift+wheel becomes the explicit opt-in for sideways table scrolling. `forward_shift_wheel_to_horizontal_scroll` mirrors the previously-removed helper (PR #23) with one extra early-return on `modifiers.shift`. Edge pass-through is preserved so Shift+wheel at the table's left/right edge keeps moving the page. Docs updated: KEYBOARD_SHORTCUTS, ARCHITECTURE, TARGET_METRICS, LESSONS, devlog 033.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove vertical-wheel forwarding from wide table scroll areas so page scrolling no longer shifts tables sideways, while preserving horizontal access through the table scrollbar/native horizontal input. This stemmed from this open issue: #22
I see it was intended to do that originally, so wondering if we want to keep this behavior? @aydiler I did test this, and scrolling now is smooth without nudging or shifting of the tables left and right. Horizontal bar still works perfectly. Thoughts?
Video below of before and after. Left is Before, Right is After.
screenrecording-2026-05-23_18-55-26.mp4