Skip to content

fix: stop table scroll wheel nudging#23

Merged
aydiler merged 1 commit into
aydiler:mainfrom
aki1ro:fix/table-scroll-wheel
May 24, 2026
Merged

fix: stop table scroll wheel nudging#23
aydiler merged 1 commit into
aydiler:mainfrom
aki1ro:fix/table-scroll-wheel

Conversation

@aki1ro
Copy link
Copy Markdown
Contributor

@aki1ro aki1ro commented May 24, 2026

Remove vertical-wheel forwarding from wide table scroll areas so page scrolling no longer shifts tables sideways, while preserving horizontal access through the table scrollbar/native horizontal input. This stemmed from this open issue: #22

I see it was intended to do that originally, so wondering if we want to keep this behavior? @aydiler I did test this, and scrolling now is smooth without nudging or shifting of the tables left and right. Horizontal bar still works perfectly. Thoughts?

Video below of before and after. Left is Before, Right is After.

screenrecording-2026-05-23_18-55-26.mp4

Remove vertical-wheel forwarding from wide table scroll areas so page scrolling no longer shifts tables sideways, while preserving horizontal access through the table scrollbar/native horizontal input.

Co-Authored-By: OpenClaude (gpt-5.5) <openclaude@gitlawb.com>
@aki1ro aki1ro changed the title fix: stop table wheel nudging fix: stop table scroll wheel nudging May 24, 2026
Copy link
Copy Markdown
Owner

@aydiler aydiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal — matches the trade-off discussed in #22 (default wheel stays with the page). I'll add a Shift+wheel opt-in in a follow-up so wide-table horizontal scroll is still reachable without dragging the bottom bar.

@aydiler aydiler merged commit 829c6af into aydiler:main May 24, 2026
2 checks passed
aydiler added a commit that referenced this pull request May 24, 2026
Restores the wheel-to-x table-scroll ergonomic from issue #4 but gates it on
the Shift modifier, so plain wheel still scrolls the document (#22) while
Shift+wheel becomes the explicit opt-in for sideways table scrolling.

`forward_shift_wheel_to_horizontal_scroll` mirrors the previously-removed
helper (PR #23) with one extra early-return on `modifiers.shift`. Edge
pass-through is preserved so Shift+wheel at the table's left/right edge keeps
moving the page.

Docs updated: KEYBOARD_SHORTCUTS, ARCHITECTURE, TARGET_METRICS, LESSONS,
devlog 033.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants