Backend for async SQLAlchemy ORM

[il-s]

Hi, I liked the idea of ​​your project and needed to make a fastapi router that will work with SQLAlchemy in asynchronous mode.

Also this answers issue number #87

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/EAS4myHY5LcKjZqzoaV1XjS28kmP
✅ Preview: https://fastapi-crudrouter-git-fork-il-s-master-flortz.vercel.app

[michaeltoohig]

Wow, I was just working on this myself after abandoning ormar in favor of using async sqlalchemy but yours looks great and I hope it is merged quickly.

[awtkns]

Hi @il-s thanks for this! Sorry for the delay, I've been quite busy.

I am totally on board with adding support for this, however I have a couple questions:

1. Instead of a brand new implementation, do you think it would be better to simply have async=true as an optional parameter?
2. For this to be merged, the implementation will need to be added to the test suite. Did you need help with that?

Thanks again for this 🚀

[il-s]

@awtkns
ok i will try to implement option 1 (with async = true parameter)

[il-s]

for the test, I used db_func like so:

from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import declarative_base, sessionmaker

Base = declarative_base()

class AsyncDatabaseSession:
    def __init__(self):
        self._session = None
        self._engine = None
    def __getattr__(self, name):
        return getattr(self._session, name)
    async def init(self):
        self._engine = create_async_engine(
            "postgresql+asyncpg://postgres:postgres@localhost/postgres",
            echo=True,
        )

        self._session = sessionmaker(
            self._engine, expire_on_commit=True, class_=AsyncSession
        )()

main_session = AsyncDatabaseSession()

async def get_db():
    yield main_session._session
    await main_session._session.commit()

`

[il-s]

@awtkns, need review!

[awtkns]

HI @il-s, looking good!

I am hoping to get this in and released tomorrow! I just need to add it to the test framework and write some documentation for it 🚀

[il-s]

@awtkns
Any ideas on how to do a merge?

[JonasKs]

Hi @awtkns , any status on this?

[jdwil]

Just fyi... my team noticed this doesn't work with PK's not named "id". I think this code might work better:

Suggested change

	select(self.db_model).where(self.db_model.id == item_id)
	select(self.db_model).where(getattr(self.db_model, self._pk) == item_id)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
fastapi-crudrouter	✅ Ready (Inspect)	Visit Preview	Jan 11, 2023 at 7:08AM (UTC)

[VolDr]

Any updates?