Deduplicate fetch commands by SHA before parallel processing#52
Open
InlinePizza wants to merge 1 commit intoawslabs:mainfrom
Open
Deduplicate fetch commands by SHA before parallel processing#52InlinePizza wants to merge 1 commit intoawslabs:mainfrom
InlinePizza wants to merge 1 commit intoawslabs:mainfrom
Conversation
When running git clone -vvv, noticed that the bundle for main was being downloaded twice in parallel. Git sends duplicate fetch commands for the same SHA when HEAD and a branch ref point to the same commit. These parallel downloads were clobbering each other's file writes. Deduplicates commands by SHA before processing to avoid redundant parallel downloads of the same bundle.
Contributor
|
Hi, Please add an issue with the necessary information to verify the problem and relevant tests that should fail with before the fix and work after this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running git clone -vvv, I noticed that the bundle file for main was being downloaded twice in parallel. Git sends duplicate fetch commands for the same SHA when HEAD and a branch ref point to the same commit. I'm not positive but I think these parallel downloads were clobbering each other's file writes.
Deduplicates commands by SHA before processing to avoid redundant parallel downloads of the same bundle
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.