-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Swift: Added video generation example code for Nova Reel, Amazon Bedrock #7459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending correction of line 78 issue.
prompt: "A pomegranate juice in a railway station", | ||
outputS3Uri: bucket | ||
) | ||
print(f"Job started with invocation ARN: {invocation_arn}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This syntax doesn't work. Isn't this a Python syntax? Shouldn't this instead be print("Job started with invocation ARN: \(invocation_arn)")
?
If it works for you, I'd be interested to know how, since I get syntax errors on these lines:
76 | outputS3Uri: bucket
77 | )
78 | print(f"Job started with invocation ARN: {invocation_arn}")
| `- error: expected ',' separator
79 |
80 | // Poll for job completion
/Users/ericsh/tmp/reel/Sources/main.swift:78:11: error: cannot find 'f' in scope
76 | outputS3Uri: bucket
77 | )
78 | print(f"Job started with invocation ARN: {invocation_arn}")
| `- error: cannot find 'f' in scope
79 |
80 | // Poll for job completion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this issue is fixed, LGTM.
@monadierickx can you make this tiny update ? Thank you |
Apologies for the delay, I fixed my mistake and the code should work correctly now. |
Fix SoS tags
Add model access prerequisite to Swift readme
…enario_user_pool_with_mfa (awsdocs#7454) Bump aws-cdk-lib in /resources/cdk/cognito_scenario_user_pool_with_mfa Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.189.0 to 2.189.1. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.189.1/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-version: 2.189.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…wsdocs#7455) * SqsExtendedClientExample added
…7430) added the new header example
…ssic-2 (awsdocs#7445) * Add .local config * Add Nova Text PHP example * Remove PHP examples for Jurassic-2 (deprecated) * Regenerate docs * Revert add .gitattributes * Fix formatting
Bumps [axios](https://github.com/axios/axios) to 1.9.0 and updates ancestor dependency [@ailly/cli](https://github.com/DavidSouther/ailly). These dependencies need to be updated together. Updates `axios` from 1.6.8 to 1.9.0 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.8...v1.9.0) Updates `@ailly/cli` from 1.2.5-rc1 to 1.6.0 - [Release notes](https://github.com/DavidSouther/ailly/releases) - [Commits](https://github.com/DavidSouther/ailly/commits/v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.9.0 dependency-type: indirect - dependency-name: "@ailly/cli" dependency-version: 1.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…av2/example_code/sqs-jms (awsdocs#7468) Bump org.springframework:spring-context in /javav2/example_code/sqs-jms Bumps [org.springframework:spring-context](https://github.com/spring-projects/spring-framework) from 6.1.14 to 6.1.20. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.1.14...v6.1.20) --- updated-dependencies: - dependency-name: org.springframework:spring-context dependency-version: 6.1.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…analyzer (awsdocs#7467) Bump degenerator and aws-cdk Removes [degenerator](https://github.com/TooTallNate/proxy-agents/tree/HEAD/packages/degenerator). It's no longer used after updating ancestor dependency [aws-cdk](https://github.com/aws/aws-cdk-cli/tree/HEAD/packages/aws-cdk). These dependencies need to be updated together. Removes `degenerator` Updates `aws-cdk` from 1.87.1 to 1.203.0 - [Release notes](https://github.com/aws/aws-cdk-cli/releases) - [Commits](https://github.com/aws/aws-cdk-cli/commits/HEAD/packages/aws-cdk) --- updated-dependencies: - dependency-name: degenerator dependency-version: dependency-type: indirect - dependency-name: aws-cdk dependency-version: 1.203.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) to 1.9.0 and updates ancestor dependency [@ailly/core](https://github.com/DavidSouther/ailly). These dependencies need to be updated together. Updates `axios` from 0.26.1 to 1.9.0 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.26.1...v1.9.0) Updates `@ailly/core` from 1.2.5-rc1 to 1.6.0 - [Release notes](https://github.com/DavidSouther/ailly/releases) - [Commits](https://github.com/DavidSouther/ailly/commits/v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.9.0 dependency-type: indirect - dependency-name: "@ailly/core" dependency-version: 1.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bda_triggers/.cdk (awsdocs#7469) Bump braces in /gov2/workflows/user_pools_and_lambda_triggers/.cdk Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ipt (awsdocs#7470) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@shepazon code is fixed and branch is updated. Can you review again ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very small nitpick. The directory name for this example uses underscores while the previously existing example in the same directory uses hyphens for word separation. Ideally these would be the same. I won't insist on changing it but I'd be delighted if it were. :)
Other than that, LGTM.
I noticed the inconsistency too. I propose to fix this in a separate PR once the open PR's are merged. As that would allow me to make all bedrock runtime code examples consistent. If that is the way you want to go, would you prefer all hyphens, underscores or CamelCasing? The convention within the code examples was not clear to me. |
This pull request includes a basic video generation code example, modeled after the python example.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.