Override the name of the SSCD to the correct value #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 55.95% 55.95%
=======================================
Files 11 11
Lines 999 999
=======================================
Hits 559 559
Misses 425 425
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThirdEyeSqueegee
approved these changes
Jul 26, 2025
vedant-jaiswal
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Closes #496
When performing a Helm installation with the name
secrets-store-csi-driver-provider-aws, the name will be passed to both the driver and provider daemonsets. This will cause the provider daemonset to fail to install since the driver will already have the name.Override the name of the SSCD dependency chart to always be
secrets-store-csi-driver.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.