-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Correct source code 'dependencies' parameter to 'requirements' #5467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct source code 'dependencies' parameter to 'requirements' #5467
Conversation
aviruthen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming that requirements variable doesn't need to be placed in list format (e.g. requirements = [source_code.requirements] if source_code.requirements else [])? If testing is okay with just a direct change then great! Looks good to me otherwise!
a25bbda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sagemaker-serve tests ran successfully a codebuild job in prod account and they are successful, merging this PR.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.