Skip to content

fix: fix evaluate_base_model flag #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
soksamnanglim wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Draft

fix: fix evaluate_base_model flag #5461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-train/src/sagemaker/train/evaluate/benchmark_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class BenchMarkEvaluator(BaseEvaluator):

benchmark: _Benchmark
subtasks: Optional[Union[str, List[str]]] = None
evaluate_base_model: bool = False
evaluate_base_model: bool = True
_hyperparameters: Optional[Any] = None


Expand Down
2 changes: 1 addition & 1 deletion sagemaker-train/src/sagemaker/train/evaluate/custom_scorer_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class CustomScorerEvaluator(BaseEvaluator):
_hyperparameters: Optional[Any] = None

# Template-required fields
evaluate_base_model: bool = False
evaluate_base_model: bool = True

@validator('dataset', pre=True)
def _resolve_dataset(cls, v):
Expand Down
2 changes: 1 addition & 1 deletion sagemaker-train/src/sagemaker/train/evaluate/llm_as_judge_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class LLMAsJudgeEvaluator(BaseEvaluator):
custom_metrics: Optional[str] = None

# Template-required fields
evaluate_base_model: bool = False
evaluate_base_model: bool = True

@validator('dataset', pre=True)
def _resolve_dataset(cls, v):
Expand Down
Loading