Add secure diagnostics endpoint with authentication to etcadm controller #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshvenkata
requested review from
2ez4szliu,
abhay-krishna,
abhinavmpandey08,
ahreehong,
drewvanstone,
g-gaston,
ndeksa,
panktishah26,
pokearu,
rahulbabu95,
sp1999,
tatlat and
vivek-koppuru
as code owners
rajeshvenkata
removed request for
2ez4szliu,
abhay-krishna,
abhinavmpandey08,
ahreehong,
drewvanstone,
g-gaston,
ndeksa,
panktishah26,
pokearu,
rahulbabu95,
sp1999,
tatlat and
vivek-koppuru
rajeshvenkata
force-pushed
the
add-capi-diagnostic
branch
from
2bbf6c6 to
5960eca
Compare
rajeshvenkata
force-pushed
the
add-capi-diagnostic
branch
from
5960eca to
9f92834
Compare
sp1999
reviewed
Nov 4, 2025
Member
There was a problem hiding this comment.
How did you test these changes? Can you add it in the description?
Member
|
/lgtm |
sp1999
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add secure diagnostics endpoint with authentication to etcdadm controller manager
Testing
Created docker cluster and followed https://cluster-api.sigs.k8s.io/tasks/diagnostics#via-kubectl to test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.