Set up GPU nodes for nvidia tests #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatlat
reviewed
Jun 4, 2025
test/e2e/os/arch.go
Outdated
| @@ -94,8 +105,16 @@ func getAmiIDFromSSM(ctx context.Context, client *ssm.Client, amiName string) (* | |||
| } | |||
|
|
|||
| // an unknown size and arch combination is a coding error, so we panic | |||
| func getInstanceTypeFromRegionAndArch(_ string, arch architecture, instanceSize e2e.InstanceSize) string { | |||
| instanceType, ok := instanceSizeToType[arch][instanceSize] | |||
| func getInstanceTypeFromRegionAndArch(_ string, arch architecture, instanceSize e2e.InstanceSize, gpuInstance bool) string { | |||
There was a problem hiding this comment.
Could we avoid using boolean arguments? It can make code less readable and less extensible. An enum approach might be better. Maybe something like this:
const (
StandardInstance InstanceCategory = iota
GPUInstance
)
func getInstanceTypeFromRegionAndArch(_ string, arch architecture, instanceSize e2e.InstanceSize, category InstanceCategory)
| @@ -98,7 +98,7 @@ var _ = Describe("Hybrid Nodes", func() { | |||
| k8sVersion = test.OverrideNodeK8sVersion | |||
| } | |||
|
|
|||
| testNode := test.NewTestNode(ctx, instanceName, nodeName, k8sVersion, nodeOS, provider, e2e.Large) | |||
| testNode := test.NewTestNode(ctx, instanceName, nodeName, k8sVersion, nodeOS, provider, e2e.Large, false) | |||
There was a problem hiding this comment.
This is what I meant by less readable code. I don't know what "false" means here.
junpengdev
force-pushed
the
setup_nvidia_test
branch
from
23d209e to
fd3e73a
Compare
tatlat
previously approved these changes
Jun 9, 2025
junpengdev
force-pushed
the
setup_nvidia_test
branch
from
fd3e73a to
167061f
Compare
tatlat
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In this PR, I am setting up hybrid nodes for nvidia test. It doesn't belong to add-on test as the nodes require specialized hardware. I modified
InstanceTypefunc inNodeadmOSinterface to acceptgpuInstanceflag. When this flag is set to true, it choose instance type amongg4dn.xlarge,g4dn.2xlarge,g5g.xlarge,g5g.2xlarge, based on architecture and instance size.Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.