Merge master into feature/flare-mega #7501
Open
+123,512
−32,620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
## Problem related aws/language-servers#2058 Edits as a newly introduced feature, previously the implementation was living in the same flow as Completion. However the 2 suggestion types have few different product requirements, thus we decided to completely separate these 2 suggestions out in terms of their code path. Key difference - Language server will process Completion request on receiving request from IDE clients, and will BLOCK following requests if in-flight request is not fulfilled yet. Edits, on the other hand, it debounces/delay the execution time for the sake of "latest" file context to ensure the suggestion reflects the CORRECT changes users attempt to make. - Triggering heuristic. For example, Completion is not supposed to be invoked when users are deleting the code, whereas Edits allow such scenario to go through. ## Solution - Introduce a new `onEditCompletion` language server API which is purely for Edits suggestion. - Invoke 2 Flare API and serve the response which first arrives (First come first served). - Allow Edits suggestion on code deletion --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem Sometimes a `.yaml` file QCT asks for from the customer is malformed and users don't see what exactly is wrong. ## Solution Validate the file and provide a more specific error message. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]> Co-authored-by: invictus <[email protected]> Co-authored-by: Laxman Reddy <[email protected]>
## Problem Job history-related code is scattered throughout various files, making it difficult to review and understand. ## Solution Centralize existing history functions in a new file and add helper functions to declutter transformation flow. Update and simplify unit tests accordingly. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem discard when it's not yet shown. reject when user's typing and makes the diff invalid. ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…or agentic chat (#7857) ## Problem In order to set appropriate Origin Info on LSP side for SMAI CodeEditor, [link](https://github.com/aws/language-servers/blob/68adf18d7ec46a7ecf9c66fd9d52b1b8f7bc236e/server/aws-lsp-codewhisperer/src/shared/utils.ts#L377), clientInfo needs to be distinct - related [PR to support SMUS](#7817) ## Solution - To check if the environment is SageMaker and a Unified Studio instance and set corresponding clientInfo Name which is ```AmazonQ-For-SMUS-CE``` ## Testing - Built artefact locally using ```npm run compile && npm run package``` and tested on a SMAI CE space - Ran ```npm run test -w packages/toolkit``` which succeeded - LSP logs show the respective client Info details ``` --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Laxman Reddy <[email protected]>
…7839) ## Problem Inline completion suggestions were being shown even when edit suggestions were active, creating a confusing user experience where both types of suggestions could appear simultaneously. ## Solution 1. Added conflict prevention logic in provideInlineCompletionItems() to check for active edit suggestions using the existing aws.amazonq.editSuggestionActive context flag 1. Created isEditSuggestionActive() method to encapsulate context checking 1. Implemented DISCARD telemetry for completion suggestions that can't be shown due to active edits 1. Added unit tests covering the new functionality, including edge cases for mixed suggestion types and items without IDs 1. Updated displayImage.ts to properly set/unset the context flag when edit suggestions are displayed/cleared 1. The solution ensures only one type of suggestion is active at a time while maintaining telemetry compliance and following existing codebase patterns. --- Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time. Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
**Description** Added credential providers for DER, Project role credentials and Connections credentials. Added in memory caching for now. The credential providers currently are structured so that it can be used with CredentialStore but a lot of things to do with credential store is really old. In the coming days, while we do bug bashes and tests, if the in memory caching fares well enough, will simplify the credential provider to implement the AWS SDK CredentialProvider directly. **Motivation** Support auth for SMUS and ensure all clients get credentials and don't fail due to lack of credentials. **Testing Done** Updated unit tests and tested flow locally. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Bhargava Varadharajan <[email protected]>
## Problem The AWS Toolkit VSCode project lacked a streamlined release candidate workflow. Creating release candidates would require manual branch creation and version management. ## Solution Added automated release candidate support: - Created `.github/workflows/setup-release-candidate.yml `- Workflow to create RC branches with automatic version bumping - Supports `Major/Minor/Patch/Custom` version increments - Reads and increments both `toolkit` and `amazonq` package versions independently - Creates date-based RC branches (`rc-YYYYMMDD`) - Commits version changes and pushes the RC branch - Updated `.github/workflows/release.yml` - Added support for `release/* ` branches - Automatically creates `rc-*` prefixed releases for release candidate branches - Proper release naming for RC artifacts This enables a clean RC workflow: trigger the setup workflow with a commit ID and version increment type, then the release pipeline automatically handles the rest. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem The release candidate workflow was failing with "protected branch update failed" error because the default `GITHUB_TOKEN ` did not exist. ## Solution Updated the workflow to use `RELEASE_CANDIDATE_BRANCH_CREATION_PAT` instead of `GITHUB_TOKEN` in the checkout step. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…es away (#7868) ## Problem Amazon Q edit suggestions remain active even when users navigate far away from the suggestion location, leading to confusion and potential unintended edits when users accept suggestions they can no longer see. ## Solution Added automatic rejection of edit suggestions when the cursor moves more than 25 lines away from the suggestion location. Implemented cursor change listener with proper cleanup to prevent memory leaks and ensure suggestions are only accepted when contextually relevant. Fixed 2 failing recommendationService.test.ts tests --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem The prerelease workflow is configured to run on branches matching release/*. The RC creation workflow previously created branches like `rc-YYYYMMDD` instead of `release/rc-YYMMDD`, which did not match the trigger pattern, meaning the prerelease workflow was never invoked automatically. As it stands now any team member with write access can perform workflow_dispatch injection. ## Solution Update the RC creation workflow to create branches in the format `release/rc-YYYYMMDD` instead of `rc-YYYYMMDD`, ensuring they match the prerelease workflow’s `release/*` branch trigger and are picked up for prerelease builds. Sanitize the input fields via Github environment variables --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem SMUS users need Project Space management functionality ## Solution - Add SageMakerUnifiedStudioSpaceNode for individual space representation - Add SageMakerUnifiedStudioSpacesParentNode for space container management - Add SagemakerSpace class for unified space operations and status management - Enhance SageMaker credential mapping with SMUS project support - Add space-specific icons and detached server credential resolution - Update SageMaker commands and model types for space functionality - Added test cases. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. ###Note: Due to lot of constriants - I apologies that I had to raise such a big PR. Co-authored-by: guntamb <[email protected]>
## Problem We only need to create the branch. The bumping of the version will be handled by the release pipeline scripts. See github scripts under: [github.com/aws/aws-toolkit-vscode/tree/master/buildspec/release](https://github.com/aws/aws-toolkit-vscode/tree/master/buildspec/release) - `10changeversion.yml`: Removes `-SNAPSHOT` from version and creates git release tag - `40pushtogithub.yml`: Bumps to next development version with `-SNAPSHOT` suffix and pushes to GitHub - `50githubrelease.yml`: Creates official GitHub release with `.vsix` files and SHA384 hashes ## Solution Remove the logic to bump the version --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem The inline completion in Jupyter Notebook is not working. https://github.com/aws/aws-toolkit-vscode/pull/7086/files is gone after inline completion migration to language server. ## Solution 1. Re-implement inline completion in Notebook 2. Re-organize the left and right context given precise cursor position in current cell. Requires aws/language-servers#2114 <img width="723" height="429" alt="Screenshot 2025-08-12 at 4 09 28 PM" src="https://github.com/user-attachments/assets/8335360b-7a83-431c-b967-0547cb60a48a" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
build(amazonq): merge release candidate version rc-20251119
## Problem Remote debugging doesn't work well on custom function types which doesn't support SnapStart ## Solution disable until it's supported --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Austin Jang <[email protected]> Co-authored-by: Arkaprava De <[email protected]> Co-authored-by: Roger Zhang <[email protected]>
## Problem need createToken metric ## Solution add createToken metric ## Testing <img width="1510" height="131" alt="vsc" src="https://github.com/user-attachments/assets/496bd6dc-dce3-4ddb-9471-f55aad6b27a0" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Notes: This merges the released changes for rc-20251120 into main. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <>
## Description This PR merges changes to add support in SMUS to use IAM-based domains. Previously we only supported IdC-based domains and with this, customers have the flexibility to use both the authentication options. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <[email protected]> Co-authored-by: aws-ides-bot <[email protected]> Co-authored-by: Bhargava Varadharajan <[email protected]> Co-authored-by: kzr <[email protected]> Co-authored-by: Laxman Reddy <[email protected]> Co-authored-by: Sherry Lu <[email protected]> Co-authored-by: Sherry Lu <[email protected]> Co-authored-by: zulil <[email protected]> Co-authored-by: Zulin Liu <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Hasani <[email protected]> Co-authored-by: Arkaprava De <[email protected]> Co-authored-by: Arkaprava De <[email protected]> Co-authored-by: Keyu Wu <[email protected]> Co-authored-by: chungjac <[email protected]> Co-authored-by: aws-asolidu <[email protected]> Co-authored-by: Newton Der <[email protected]> Co-authored-by: Newton Der <[email protected]> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Boyu <[email protected]> Co-authored-by: atontb <[email protected]> Co-authored-by: Richard Li <[email protected]> Co-authored-by: Shruti Sinha <[email protected]> Co-authored-by: Bhavya Sharma <[email protected]> Co-authored-by: Roger Zhang <[email protected]> Co-authored-by: Tai Lai <[email protected]> Co-authored-by: invictus <[email protected]> Co-authored-by: Dylan Ross <[email protected]> Co-authored-by: BlakeLazarine <[email protected]> Co-authored-by: Blake Lazarine <[email protected]> Co-authored-by: tobixlea <[email protected]> Co-authored-by: seshubaws <[email protected]> Co-authored-by: Bhavya Sharma <[email protected]> Co-authored-by: manodnyab <[email protected]>
…t interrupting execution (#8346) ## Problem - User experiences pop up error when connecting with a stopped space. - Attempt to connect without waiting for space to transition to running state. - Listing needs to check all clusters without stopping execution flow on initial discovered error ## Solution - Added delay for space to fully transition state before attempting to connect - Change throwing error to logging warnings --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Laxman Reddy <[email protected]>
## Problem new lambda runtime release in Nov (python3.14, nodejs24.x, java25) are currently shown as not supported in AppBuilder & remote debugging ## Solution New lambda runtime can be used in AWS Explorer, AppBuilder, and Remote Debugging. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
#8349) …n startup ## Problem New CloudFormation feature eagerly loaded stacks resulting in error notification if credentials were not set properly. Eager loading is not desirable even if credentials would work because user may not open the panel or intend to use the data. ## Solution Lazy load stacks. Tested: - stacks do not load on startup - switching regions does not eagerly load stacks - pagination with load more works as before - deploying template if stacks were never loaded triggers loading as stacks are refreshed (desired behavior) - if StacksNode is expanded and region is switched then stacks are loaded (desired behavior) Dead code removal: polling was disabled earlier and unused. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ere setting is not registered (#8343) ## Problem When the extension is upgraded and user does not do a full restart, it is possible for new cloudformation telemetry setting to not be registered yet, resulting in error trying to save it. ## Solution Skip the save and do it the next time the extension starts. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Akila Tennakoon <[email protected]> Co-authored-by: manodnyab <[email protected]>
## Problem Stacks remained in panel as REVIEW_IN_PROGRESS status after ChangeSet was deleted due to the lack of refresh. ## Solution Refresh stacks after change set deletion. On create change sets, this would clear out the stack from panel. Removing some dead code as well. Since view/delete change set is disabled from command palette the `params` would never be undefined. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem - replacement may produce '&' characters that are double-unescaped ## Solution - change the order of the .replace() calls in the decoding of both wsUrl and token such that & is decoded after all other HTML entities have been decoded - Addressing bot suggestion in #8341 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem ## Solution Disable log --tail in non snap start functions --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…g outFile auto detection (#8366) ## Problem TS remote debugging on windows was failing due to windows file pattern is malformed for glob pattern TS remote debugging on windows can't correctly apply sourceMapOverrides ## Solution Fixed issues above and not TS debug can successfully work on every OS --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
build(amazonq): merge release candidate version rc-20251125
…staller (#8364) Ensures we have visibility into LSP version selection/installation if/when customers report installation related issues. ``` 2025-11-24 17:58:10.530 [info] awsCfnLsp: Found CloudFormation LSP provider: RemoteLspServerProvider 2025-11-24 17:58:11.078 [info] awsCfnLsp: Candidate versions: 1.1.0[darwin-arm64,darwin-x64,linux-arm64,linux-x64,win32-arm64,win32-x64,windows-arm64,windows-x64], 1.0.0[darwin-arm64,darwin-x64,linux-arm64,linux-x64,win32-arm64,win32-x64,windows-arm64,windows-x64] 2025-11-24 17:58:11.078 [info] awsCfnLsp: Creating CloudFormation LSP manifest for prod 2025-11-24 17:58:12.270 [info] lsp: Finished preparing "cloudformation-languageserver" LSP server: '/Users/tennakoo/Library/Caches/aws/toolkits/language-servers/cloudformation-languageserver/1.1.0' 2025-11-24 17:58:12.312 [info] awsCfnLsp: Found CloudFormation LSP executable: /Users/tennakoo/Library/Caches/aws/toolkits/language-servers/cloudformation-languageserver/1.1.0/cloudformation-languageserver-1.1.0-darwin-arm64-node22/cfn-lsp-server-standalone.js ``` *No tests added since no business logic modified* --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Akila Tennakoon <[email protected]>
## Problem - Project node is not loading automatically after re-authentication ## Solution - After re-authentication, set the project, then refresh the node ## User experience - the user will see select project popup after re-authentication --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Build User <[email protected]>
… catalog (#8363) ## Problem A bug is reported that when s3 table catalog is empty, there is getDatabases call being made and cause unwanted error ## Solution Handle the issue by not calling getDatabases when a catalog node is an empty parent node --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Zulin Liu <[email protected]>
…re remote connections (#8328) ## Problem When attempting to connect to a SageMaker Space, if the user's SSH config has syntax errors (even outside the sm_* section), users would see a cryptic error message: ```ssh check against host failed: 255``` This error message: Didn't explain what was wrong Didn't indicate it was an SSH config issue Didn't provide a way to fix the problem ## Solution Enhanced the SSH configuration error handling to provide a better user experience: Shows a clear message explaining the issue. Displays the actual SSH error (including line numbers) Provides an "Open SSH Config" button to directly open the config file for editing https://github.com/user-attachments/assets/ef4f5a0f-0525-4e4c-9e96-a2081997dd81 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…rget old linux builds (#8383) ## Problem * Fix potential GitHub API rate limiting issue * Use older build of linux for older machines ## Solution * Attempt using manifest json to resolve cfn lsp versions, fallback to original GitHub releases approach * When in a sandbox environment, or required version of GLIC is not available, use older version of linux build --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic merge failed
Command line hint
To perform the merge from the command line, you could do something like the following (where "origin" is the name of the remote in your local git repo):