Add unit tests for existing S3PostUploadSignedPolicy class and fix exception message #3897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string.Format
was missing the parameter for{0}
in the function call. The unit tests caught this issue.Motivation and Context
For implementing #1901 we are moving the
S3PostUploadSignedPolicy
class out of the _bcl folder so that other frameworks (net standard/core 3.1, and the existing netframework) can utilize it. In order to ensure that we do not break anything during this move, i am adding unit tests which validate the current functionality. This way once we make changes in the future we can easily determine if we break things.Please note that we only run unit tests in netframework but this should at least catch potential future issues for netframework. For other frameworks we can copy/run these unit tests in a console app when testing.
Testing
6b777a12-a351-46a6-9b45-89f4f98ad46a
passTypes of changes
Checklist
License