Skip to content

fix(rt): reject CR and LF in ECS authorization tokens #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JerimothLau wants to merge 4 commits into from
+11 −3
Closed

fix(rt): reject CR and LF in ECS authorization tokens #1964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f64a43
fix(rt): reject line breaks in ECS auth tokens
JerimothLau Jul 31, 2026
6a79ce6
fix(rt): reject CR and LF in ECS authorization tokens
JerimothLau Jul 31, 2026
59df360
fix(rt): reject line breaks in ECS auth tokens
JerimothLau Jul 31, 2026
3dafade
Merge branch 'aws:main' into fix/ecs-auth-token-linebreaks
JerimothLau Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/0b4c83e2-93d6-47f1-bcf3-83233e4438b2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"id": "0b4c83e2-93d6-47f1-bcf3-83233e4438b2",
"type": "bugfix",
"description": "Reject carriage return and line feed characters in ECS container authorization tokens",
"module": "aws-config"
}
2 changes: 1 addition & 1 deletion ...e/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/EcsCredentialsProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public class EcsCredentialsProvider(
?: AwsSdkSetting.AwsContainerAuthorizationToken.resolve(platformProvider)
?: return null

if (token.contains("\r\n")) {
if (token.contains('\r') || token.contains('\n')) {
throw CredentialsProviderException("Token contains illegal line break sequence.")
}

Expand Down
6 changes: 4 additions & 2 deletions ...-config/common/test/aws/sdk/kotlin/runtime/auth/credentials/EcsCredentialsProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ class EcsCredentialsProviderTest {

@Test
fun testAuthTokenIllegal() = runTest {
val token = "auth\r\ntoken"
listOf("auth\rtoken", "auth\ntoken", "auth\r\ntoken").forEach { token ->
val engine = TestConnection()

val testPlatform = TestPlatformProvider.of(
Expand All @@ -400,12 +400,13 @@ class EcsCredentialsProviderTest {
assertFailsWith<CredentialsProviderException> {
provider.resolve()
}.message.shouldContain("Token contains illegal line break sequence.")
}
}

@Test
fun testAuthTokenFileIllegal() = runTest {
listOf("auth\rtoken", "auth\ntoken", "auth\r\ntoken").forEach { token ->
val tokenFile = "/path/to/token"
val token = "auth\r\ntoken"
val engine = TestConnection()

val testPlatform = TestPlatformProvider.of(
Expand All @@ -422,6 +423,7 @@ class EcsCredentialsProviderTest {
assertFailsWith<CredentialsProviderException> {
provider.resolve()
}.message.shouldContain("Token contains illegal line break sequence.")
}
}

@Test
Expand Down
Loading