chore(client-s3): bucket contextParam customization for schema-serde mode #7250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Aug 8, 2025
| // Bucket is in the http trait but is handled by endpoints ruleset. | ||
| return segment !== "{Bucket}"; | ||
| }) | ||
| .join("/") || "/"; |
There was a problem hiding this comment.
removed this hack, replaced by model preprocessing transform
kuhe
force-pushed
the
schema/logger
branch
3 times, most recently
from
cfcc887 to
6207b9d
Compare
trivikr
approved these changes
Aug 8, 2025
kuhe
force-pushed
the
schema/logger
branch
3 times, most recently
from
4c1a503 to
5dc79a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
smithy-lang/smithy-typescript#1600
Description
For schema-serde mode:
/{Bucket}endpoint uri prefix IFF input members group hasBucketand the member is acontextParam(trait).Testing
S3 e2e tests, integration (CI)
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?