DRAFT Enforce NFSv4#3163
Draft
gmarciani wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET: This is just a draft, validated on Ubuntu, but facing issues on AL23 and it's missing proper unit tests
Description of changes
Enforce NFSv4-only mode on the NFS server across all supported operating systems.
In particular:
nfscookbook defaults to enable NFSv4 and disable NFSv2/NFSv3.default['cluster']['nfs']['mask-nfsv2-nfsv3-services'](defaulttrue) to maskrpcbind.serviceandrpcbind.socket, preventingrpc-statdandnfs-mountdfrom starting as transitive deps ofnfs-server.service. This is done because NFsv4 does not require those services. This is exposed as a Chef attribute so customers who need NFSv2/v3 can set it tofalseto unmask those services.Tests
References
This change fixes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.