gin: Fix regMrSym hang caused by duplicate detection - #1372
Open
rauteric wants to merge 1 commit into
Open
Conversation
The plugin maintains a refcounted, address-keyed dedup cache for symmetric registrations. In case of a duplicate registration, the previous code used the existing registration and exited without participating in the all_gather, causing a hang if some ranks went through the normal registration process. (This is possible in particular if some -- but not all -- ranks deregistered the region before reregistering it.) Fix: all ranks will now go through the all_gather after local registration, even if it is a duplicate registration. Also added a functional test for this case. Signed-off-by: Eric Raut <eraut@amazon.com>
rauteric
force-pushed
the
fix/gin-symm-mr-dedup-allgather
branch
from
August 24, 2026 23:57
30ad7a7 to
3da6dab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin maintains a refcounted, address-keyed dedup cache for symmetric registrations. In case of a duplicate registration, the previous code used the existing registration and exited without participating in the all_gather, causing a hang if some ranks went through the normal registration process. (This is possible in particular if some -- but not all -- ranks deregistered the region before reregistering it.)
Fix: all ranks will now go through the all_gather after local registration, even if it is a duplicate registration. Also added a functional test for this case.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.