ML-KEM: Fix mlkem-native importer.sh #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 10a0611 broke the mlkem-native importer on MacOS (both AArch64 and x86_64) because of a missing quotation around `sed` invocations. This commit fixes this. Found by mlkem-native CI. Signed-off-by: Hanno Becker <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 78.69% 78.71% +0.02%
==========================================
Files 646 646
Lines 111213 111213
Branches 15711 15712 +1
==========================================
+ Hits 87519 87542 +23
+ Misses 23003 22977 -26
- Partials 691 694 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkostic
approved these changes
Aug 22, 2025
torben-hansen
approved these changes
Aug 22, 2025
|
@torben-hansen @dkostic Can we merge this? Then we can get rid of the mlkem-native patch. |
justsmth
approved these changes
Aug 26, 2025
mkannwischer
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Aug 28, 2025
This patch has been upstreamed in aws/aws-lc#2635 and is no longer required. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Aug 28, 2025
This patch has been upstreamed in aws/aws-lc#2635 and is no longer required. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Commit 10a0611 broke the mlkem-native importer on MacOS (both AArch64 and x86_64) because of a missing quotation around
sedinvocations. This commit fixes this.