Add x86 Keccak implementation #2619
Draft
+612
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
==========================================
- Coverage 78.72% 78.72% -0.01%
==========================================
Files 645 646 +1
Lines 111086 111216 +130
Branches 15690 15711 +21
==========================================
+ Hits 87453 87550 +97
- Misses 22941 22975 +34
+ Partials 692 691 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewhop
pushed a commit
that referenced
this pull request
Aug 25, 2025
Bit Interleave is used for performance optimizations on 32-bit platforms. Bit Interleave adds unnecessary complexity. ### Issues: Some Windows compiler, e.g., old versions of Microsoft Visual C++ (MSVC), do not support some preprocessor directives and expressions, e.g., of the type: ``` // Double-check that bit-interleaving is not used on AArch64 #if BIT_INTERLEAVE != 0 #error Bit-interleaving of Keccak1600 states should be disabled for AArch64 #endif ``` in https://github.com/aws/aws-lc/blob/d781046a99638d1466ec912cf0191d0564de2084/crypto/fipsmodule/sha/keccak1600.c#L422 A solution could be: ``` #if defined(BIT_INTERLEAVE) && BIT_INTERLEAVE #error Bit-interleaving of Keccak1600 states should be disabled for AArch64 #endif ``` However, BIT_INTERLEAVE is intended for only optimizing 32-bit platforms, i.e., it adds unnecessary complexity to the code without providing many benefits. Therefore, removing BIT_INTERLEAVE support is the better solution for clarity and maintainability. ### Description of changes: Remove all support for BIT_INTERLEAVE. ### Call-outs: This change is needed/motivated by the integration of x86 Keccak to aws-lc #2619 which fails when running on x86 Windows platform. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR is a prototype of the x86 Keccak code as part of the third party module. Once the code and the proof are merged into s2n-bignum, the s2n-bignum importer script will be used to integrate the implementation.
Testing:
ninja && ./crypto/crypto_test
./tool/bssl speed -filter {SHA3-224, ...}
SHA3 Performance: Assembly vs C Implementation Tables
SHA3-224
SHA3-256
SHA3-384
SHA3-512
SHA3 Performance: Details
ASM Implementation
C Implementation
###MLKEM Performance: Assembly vs C SHA3 Tables
ML-KEM Performance: Assembly vs C Implementation
ML-KEM-512
ML-KEM-768
ML-KEM-1024
ASM Implementation
C Implementation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.