Skip to content

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Aug 15, 2025

Issues:

Addresses CryptoAlg-3221, CryptoAlg-3220, CryptoAlg-3219, CryptoAlg-3218, CryptoAlg-3217, CryptoAlg-3216, CryptoAlg-3215, CryptoAlg-3214, CryptoAlg-3212, CryptoAlg-3211

Description of changes:

This pull request addresses and improves the experimental TLS transfer serialization feature. Primarily focusing on performance of restored connections for the SSLBuffer by improving the serialization format, and hardens the checking of the data structures on deserialization.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 13. Check the log or trigger a new build to see more.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 75.39936% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (698202b) to head (68f4ff2).

Files with missing lines Patch % Lines
ssl/ssl_buffer.cc 61.14% 68 Missing ⚠️
ssl/ssl_transfer_asn1.cc 90.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
- Coverage   78.70%   78.68%   -0.03%     
==========================================
  Files         645      645              
  Lines      111111   111333     +222     
  Branches    15689    15714      +25     
==========================================
+ Hits        87448    87597     +149     
- Misses      22970    23045      +75     
+ Partials      693      691       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skmcgrail skmcgrail force-pushed the tls-transfer branch 2 times, most recently from 85b387d to 530f170 Compare August 18, 2025 22:41
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@skmcgrail skmcgrail marked this pull request as ready for review August 19, 2025 21:22
@skmcgrail skmcgrail requested a review from a team as a code owner August 19, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants