-
Notifications
You must be signed in to change notification settings - Fork 139
TLS Transfer Serialization Improvements #2616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 13. Check the log or trigger a new build to see more.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 78.70% 78.68% -0.03%
==========================================
Files 645 645
Lines 111111 111333 +222
Branches 15689 15714 +25
==========================================
+ Hits 87448 87597 +149
- Misses 22970 23045 +75
+ Partials 693 691 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
85b387d
to
530f170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
530f170
to
17967b3
Compare
17967b3
to
68f4ff2
Compare
Issues:
Addresses CryptoAlg-3221, CryptoAlg-3220, CryptoAlg-3219, CryptoAlg-3218, CryptoAlg-3217, CryptoAlg-3216, CryptoAlg-3215, CryptoAlg-3214, CryptoAlg-3212, CryptoAlg-3211
Description of changes:
This pull request addresses and improves the experimental TLS transfer serialization feature. Primarily focusing on performance of restored connections for the SSLBuffer by improving the serialization format, and hardens the checking of the data structures on deserialization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.