-
Notifications
You must be signed in to change notification settings - Fork 139
Implement ragdoll #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement ragdoll #2615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 255. Check the log or trigger a new build to see more.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
- Coverage 78.72% 78.70% -0.03%
==========================================
Files 645 662 +17
Lines 111086 113073 +1987
Branches 15690 15928 +238
==========================================
+ Hits 87453 88991 +1538
- Misses 22941 23307 +366
- Partials 692 775 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 245. Check the log or trigger a new build to see more.
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 235. Check the log or trigger a new build to see more.
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-power.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 225. Check the log or trigger a new build to see more.
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
third_party/jitterentropy/jitterentropy-library/arch/jitterentropy-base-s390.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 215. Check the log or trigger a new build to see more.
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-foldtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
...tropy-library/tests/raw-entropy/recording_runtime_kernelspace/attic/jitterentropy-lfsrtime.c
Show resolved
Hide resolved
Ragdoll merge aws/aws-lc#2615 surface that aws-lc-rs CC build type doesn't support building the CPU Jitter Entropy sub module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 205. Check the log or trigger a new build to see more.
Description of changes:
This PR moves the ragdoll implementation from the feature branch to main branch.
Most (but not all) additions are from the new import method for Jitter Entropy. After this PR, we will import from
v3.6.3
tag.There are a few additions compared to the feature branch:
build_and_test_ssl_runner_valgrind
currently overrides the defined GO timeout value. It shouldn't. So, this PR also removes that to allow the SSL Valgrind runner to finish with the slower Jitter Entropy.urandom.c
.Testing:
Existing CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.