Skip to content

Conversation

torben-hansen
Copy link
Contributor

@torben-hansen torben-hansen commented Aug 14, 2025

Description of changes:

This PR moves the ragdoll implementation from the feature branch to main branch.

Most (but not all) additions are from the new import method for Jitter Entropy. After this PR, we will import from v3.6.3 tag.

There are a few additions compared to the feature branch:

  • build_and_test_ssl_runner_valgrind currently overrides the defined GO timeout value. It shouldn't. So, this PR also removes that to allow the SSL Valgrind runner to finish with the slower Jitter Entropy.
  • Concurrently execute ssl runner tests under Valgrind to improve CI speed
  • Initialize an un-initialized variable in urandom.c.

Testing:

Existing CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner August 14, 2025 21:15
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 255. Check the log or trigger a new build to see more.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 77.25061% with 374 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.70%. Comparing base (04875db) to head (902eb1b).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crypto/rand_extra/urandom.c 35.41% 93 Missing ⚠️
crypto/fipsmodule/rand/rand_test.cc 63.15% 48 Missing and 8 partials ⚠️
crypto/fipsmodule/rand/rand_isolated_test.cc 80.37% 45 Missing and 7 partials ⚠️
...fipsmodule/rand/entropy/tree_drbg_jitter_entropy.c 83.60% 30 Missing ⚠️
...opy/jitterentropy-library/src/jitterentropy-base.c 30.95% 27 Missing and 2 partials ⚠️
crypto/test/test_util.cc 44.00% 18 Missing and 10 partials ⚠️
crypto/ube/fork_detect.c 83.13% 14 Missing ⚠️
.../entropy/tree_drbg_jitter_entropy_isolated_test.cc 91.17% 10 Missing and 2 partials ⚠️
crypto/fipsmodule/rand/rand.c 93.20% 11 Missing ⚠️
crypto/rand_extra/urandom_test.cc 81.35% 5 Missing and 6 partials ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
- Coverage   78.72%   78.70%   -0.03%     
==========================================
  Files         645      662      +17     
  Lines      111086   113073    +1987     
  Branches    15690    15928     +238     
==========================================
+ Hits        87453    88991    +1538     
- Misses      22941    23307     +366     
- Partials      692      775      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@torben-hansen torben-hansen changed the title Implements ragdoll Implement ragdoll Aug 15, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 245. Check the log or trigger a new build to see more.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 235. Check the log or trigger a new build to see more.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 225. Check the log or trigger a new build to see more.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 215. Check the log or trigger a new build to see more.

torben-hansen added a commit to aws/aws-lc-rs that referenced this pull request Aug 21, 2025
Ragdoll merge aws/aws-lc#2615 surface that aws-lc-rs CC build type doesn't support building the CPU Jitter Entropy sub module.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 205. Check the log or trigger a new build to see more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants