Skip to content

Conversation

alexw91
Copy link
Contributor

@alexw91 alexw91 commented Jul 31, 2025

Issues:

N/A

Description of changes:

Adds opt-in support for standalone MLKEM SupportedGroup for all key sizes.

Call-outs:

None

Testing:

Unit tests. I also confirmed interoperability with Openssl v3.5.

# AWS-LC Server
$ ./build/tool/bssl s_server -curves MLKEM768:MLKEM1024:MLKEM512 -accept 44330 -debug

# Openssl 3.5 Client
$ openssl3 s_client -curves MLKEM512 -connect 127.0.0.1:44330 -debug
$ openssl3 s_client -curves MLKEM768 -connect 127.0.0.1:44330 -debug
$ openssl3 s_client -curves MLKEM1024 -connect 127.0.0.1:44330 -debug

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.75%. Comparing base (12b5dd5) to head (69855b4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files         646      646           
  Lines      111238   111302   +64     
  Branches    15712    15714    +2     
=======================================
+ Hits        87600    87657   +57     
- Misses      22945    22950    +5     
- Partials      693      695    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexw91 alexw91 marked this pull request as ready for review August 25, 2025 20:16
@alexw91 alexw91 requested a review from a team as a code owner August 25, 2025 20:16
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled this PR down and confirmed the ML-KEM-only keyshare locally

Screenshot 2025-08-27 at 2 37 14 PM

SSL_GROUP_MLKEM768,
false,
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick: other struct literals have 2 newlines between , and {

justsmth
justsmth previously approved these changes Aug 29, 2025
@alexw91 alexw91 dismissed stale reviews from justsmth and WillChilds-Klein via 69855b4 August 29, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants