-
Notifications
You must be signed in to change notification settings - Fork 139
Enable Hybrid PQ KeyShares by default #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexw91
wants to merge
3
commits into
aws:main
Choose a base branch
from
alexw91:pq-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+155
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
+ Coverage 78.88% 78.90% +0.02%
==========================================
Files 640 640
Lines 109766 109779 +13
Branches 15526 15528 +2
==========================================
+ Hits 86590 86624 +34
+ Misses 22479 22457 -22
- Partials 697 698 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Jul 10, 2025
FYI: I want to hold off on merging this in until we can better quantify the impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Adds
X25519MLKEM768
KeyShare to AWS-LC's default SupportedGroups list.Call-outs:
ssl_version_test.cc
was updated to expectSSL_R_UNKNOWN_KEY_EXCHANGE_TYPE
when callingSSL_get_peer_tmp_key()
on an SSL connection that offered X25519MLKEM768. This is because there is no EVP_PKEY type for hybrid keys, only individual X25519 or MLKEM768 keys.Testing:
Unit Tests confirm that X25519MLKEM768 and X25519 are now offered by default by AWS-LC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.