feat: discover ami for unmanaged nodegroups #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mselim00
approved these changes
Oct 25, 2025
Contributor
Author
|
https://github.com/aws/aws-k8s-tester/actions/runs/18795280380/job/53641259908?pr=707#step:4:4259 the nvidia image failure is because of nccl-tests not being pinned, and there was a recent mixup with NCCL 2.28.7 where some types are not yet available in the 2.28.3 version we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
enables automatic discovery of ami ids based on userdata type for unmanaged nodegroups.
Testing:
added integration tests and ran them
--- PASS: TestAMIResolver (0.27s) --- PASS: TestAMIResolver/AL2023-nvidia (0.17s) --- PASS: TestAMIResolver/AL2023-nvidia/nvidia (0.14s) --- PASS: TestAMIResolver/AL2023-nvidia/standard (0.04s) --- PASS: TestAMIResolver/Bottlerocket (0.08s) --- PASS: TestAMIResolver/Bottlerocket/nvidia (0.04s) --- PASS: TestAMIResolver/Bottlerocket/standard (0.04s)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.