Skip to content

make cloud watch agent optional #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

make cloud watch agent optional #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions internal/deployers/eksapi/deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ type deployerOptions struct {
CapacityReservation bool `flag:"capacity-reservation" desc:"Use capacity reservation for the unmanaged nodegroup"`
ClusterCreationTimeout time.Duration `flag:"cluster-creation-timeout" desc:"Time to wait for cluster to be created and become active."`
ClusterRoleServicePrincipal string `flag:"cluster-role-service-principal" desc:"Additional service principal that can assume the cluster role"`
CloudWatchAgent bool `flag:"cloud-watch-agent" desc:"enable cloudwatch agent to deploy the cloud watch infra."`
EFA bool `flag:"efa" desc:"Create EFA interfaces on the node of an unmanaged nodegroup. One instance type must be passed if set. Requires --unmanaged-nodes and --instance-types."`
EKSEndpointURL string `flag:"endpoint-url" desc:"Endpoint URL for the EKS API"`
EmitMetrics bool `flag:"emit-metrics" desc:"Record and emit metrics to CloudWatch"`
Expand Down Expand Up @@ -241,21 +242,23 @@ func (d *deployer) Up() error {
}
}

klog.Infof("Setting up CloudWatch infrastructure...")
if roleArn, err := d.infraManager.createCloudWatchInfrastructureStack(d.cluster.name); err != nil {
klog.Errorf("CloudWatch infrastructure setup failed: %v", err)
return err
} else {
d.infra.cloudwatchRoleArn = roleArn
klog.Infof("CloudWatch infrastructure setup completed")
}
// Apply CloudWatch infrastructure manifest
manifest := templates.CloudWatchAgentRbac
if err := fwext.ApplyManifests(d.k8sClient.config, manifest); err != nil {
klog.Errorf("CloudWatch infrastructure manifest failed: %v", err)
return err
if d.CloudWatchAgent {
klog.Infof("Setting up CloudWatch infrastructure...")
if roleArn, err := d.infraManager.createCloudWatchInfrastructureStack(d.cluster.name); err != nil {
klog.Errorf("CloudWatch infrastructure setup failed: %v", err)
return err
} else {
d.infra.cloudwatchRoleArn = roleArn
klog.Infof("CloudWatch infrastructure setup completed")
}
// Apply CloudWatch infrastructure manifest
manifest := templates.CloudWatchAgentRbac
if err := fwext.ApplyManifests(d.k8sClient.config, manifest); err != nil {
klog.Errorf("CloudWatch infrastructure manifest failed: %v", err)
return err
}
klog.Infof("CloudWatch infrastructure manifest applied successfully")
}
klog.Infof("CloudWatch infrastructure manifest applied successfully")
return nil
}

Expand Down