Creating stream display to be used for text only monitoring #9915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemous
requested changes
Dec 12, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Looks good overall, requested a few small changes and had a few questions
tests/unit/customizations/ecs/expressgateway/test_stream_display.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_stream_display.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_stream_display.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_stream_display.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_managedresourcegroup.py
Show resolved
Hide resolved
jutyler1
force-pushed
the
ecs-pr-v4-02
branch
2 times, most recently
from
cb9fe99 to
a1e0434
Compare
jutyler1
force-pushed
the
ecs-pr-v4-02
branch
from
a1e0434 to
b281b0b
Compare
aemous
requested changes
Dec 15, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Looks good! Just want to migrate the expressgateway test suites to use PyTest, unittest is our legacy tests and we have since then used PyTests for new test suites.
tests/unit/customizations/ecs/expressgateway/test_managedresourcegroup.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_managedresource.py
Outdated
Show resolved
Hide resolved
aemous
reviewed
Dec 15, 2025
tests/unit/customizations/ecs/expressgateway/test_managedresource.py
Outdated
Show resolved
Hide resolved
jutyler1
force-pushed
the
ecs-pr-v4-02
branch
from
f7b9c2a to
25b5955
Compare
aemous
reviewed
Dec 15, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
requested a couple changes
tests/unit/customizations/ecs/expressgateway/test_managedresourcegroup.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_managedresourcegroup.py
Show resolved
Hide resolved
jutyler1
force-pushed
the
ecs-pr-v4-02
branch
from
25b5955 to
da6f3ea
Compare
aemous
merged commit 7184988
into
aws:ecs-express-gateway-text-only
44 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Creating stream display to be used for text only monitoring. This display is not hooked up for usage yet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.