Skip to content

[v2] Use AssertionError instead of unittest.TestCase.fail for S3 memory assertion integration tests #9873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

[v2] Use AssertionError instead of unittest.TestCase.fail for S3 memory assertion integration tests #9873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c105b78
Use AssertionError instead of unittest fail
kdaily Nov 24, 2025
edfe92a
Use standard assertion
kdaily Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions tests/integration/customizations/s3/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,17 +1544,12 @@ def use_classic_transfer_client(self, aws_config_copy):

def assert_max_memory_used(self, process, max_mem_allowed, full_command):
peak_memory = max(process.memory_usage)
if peak_memory > max_mem_allowed:
failure_message = (
'Exceeded max memory allowed (%s MB) for command '
'"%s": %s MB'
% (
self.max_mem_allowed / 1024.0 / 1024.0,
full_command,
peak_memory / 1024.0 / 1024.0,
)
)
self.fail(failure_message)

assert peak_memory <= max_mem_allowed, (
"Exceeded max memory allowed "
f"({max_mem_allowed / 1024.0 / 1024.0} MB) for command "
f'"{full_command}": {peak_memory / 1024.0 / 1024.0} MB'
)

def test_transfer_single_large_file(self, files, shared_bucket):
# 40MB will force a multipart upload.
Expand Down
Loading