This repository was archived by the owner on May 31, 2024. It is now read-only.

fix: temporary MANIFEST.json is created and combined with file path from --inputsFile #527

Open

sonjand wants to merge 15 commits into aws:main from sonjand:main

sonjand commented Oct 10, 2022

Issue #, if available: 474

Description of Changes

added new function parseAndAddToManifest()that allows users to use a MANIFEST.json file and include a file with the --inputsFile flag without any overriding.

Description of how you validated changes

Various calls of make and workflow run were used to test creation of new file, as well as its eventual deletion.

Checklist

If this change would make any existing documentation invalid, I have included those updates within this PR
I have added unit tests that prove my fix is effective or that my feature works
I have linted my code before raising the PR
Title of this Pull Request follows Conventional Commits standard: https://www.conventionalcommits.org/en/v1.0.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Jonathan Sandoval added 6 commits

September 27, 2022 10:21


          MANIFEST.json is copied

c02d0c5


          added manifest struct for parsing

0a4d89f


          inputsFile now added to MANIFEST

bc40873


          code added to test suite for parsing function


          added parsing function to workflow run

a7a779e


          added debugging logs and refactored parse function

97f03fe

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/workflow_run_test.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

Jonathan Sandoval added 3 commits

October 11, 2022 12:54


          refactored manager.go for readability

78d90b8


          changed name of new function

c1d1a36


          refactored for readability and changed directory name

cebd1ab

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/workflow_run_test.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Show resolved Hide resolved

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/workflow_run.go Outdated Show resolved Hide resolved

Jonathan Sandoval added 2 commits

October 12, 2022 16:42


          refactored workflow run to use same temp folder to avoid duplication

9b281eb


          removed comments

16287a6

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/manager.go Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/workflow_run.go Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved


          code refactored for workflow run to work

d187776

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/manager.go Outdated Show resolved Hide resolved


          updated code to upload input

baf33b6

lingjiekong reviewed

View reviewed changes

packages/cli/internal/pkg/cli/workflow/workflow_run.go Show resolved Hide resolved

packages/cli/internal/pkg/cli/workflow/manager.go Show resolved Hide resolved

Jonathan Sandoval added 2 commits

October 18, 2022 09:55


          updated input required logic

b027fa1


          refactored logic for wes adapter

be0877a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet