Repository navigation
fix missingSACounter metric - #247
Merged
Merged
Conversation
modulitos
force-pushed
the
fix-sa-cache-missed-metric
branch
from
November 27, 2024 23:56
98d0037 to
2d7664d
Compare
modulitos
force-pushed
the
fix-sa-cache-missed-metric
branch
from
November 28, 2024 00:05
2d7664d to
2f0cd53
Compare
haoranleo
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes a false-positive case where
pod_identity_webhook_missing_sa_countincrements when the SA is present, yet missing PI annotations. Since the SA is technically in the cache, the counter shouldn't increment.We added this metric here: #246
We want this metric to only count cases where
pod.spec.serviceAccountNamereferences an SA that is missing in the cache.(also note that if
pod.spec.serviceAccountNamereferences a non-existent SA, PI Webhook will not receive the request because API server will refuse to create the pod)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.