Add DescribeLogGroups/PutRetentionPolicy rate limiter #1695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
DescribeLogGroups (DLG) and PutRetentionPolicy (PRP) are getting throttled when there are either high deployment of agents and/or high number of log groups configured.
Description of changes
Adding a rate limiter for both DLG and PRP that limits to one operation call per second.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
a. This test is done for both DLG and PRP
You may notice that a mutex is used for the call times array, that's because the
data-race-check
would fail since multiple go routines are writing to that array.Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint