Repository navigation
Conversation
added 2 commits
May 13, 2025 11:53
lisguo
changed the title
lisguo
changed the title
Contributor
|
This PR was marked stale due to lack of activity. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
We added the awsentity processor to the container insights pipeline including the
add_entityflag for the emfexporter.This causes a problem where the entity processor tries to get the service name and now it overrides the EMF log's
Servicefield which is unintended. This creates the wrong metric dimension and high cardinality metrics.Bad:
"Service": "busybox-service-jn9tc"Good:
"Service": "busybox-service"Description of changes
Add an allow list to the awsentity processor to only allow entity attributes to be appended to the telemetry. For container insights we will only append the platform type:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
make test
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint