feat: Implement TUI for identity - #1886
Open
nborges-aws wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor #1886 +/- ##
============================================
- Coverage 95.98% 95.67% -0.32%
============================================
Files 208 228 +20
Lines 9636 10448 +812
============================================
+ Hits 9249 9996 +747
- Misses 387 452 +65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is built upon and depends on #1856. Should not be merged until previous PR is, at which point diff will correctly render.
Description
Adds read-only TUI screens for inspecting Identity credential providers
identity api-key-credential-provider— interactive menu, list picker, and get detail viewidentity oauth2-credential-provider— interactive menu, list picker, and get detail viewCliOnlyScreen, which points user at the equivalent CLI command (e.g. This operation is available in the CLI:agentcore identity api-key-credential-provider create --help)maxPageSizeto thePaginatedTablePicker. Identity list API caps maxResults at 20, which caused issues when calling list/get from a tall terminal. The calculation was based on terminal height and could easily exceed 20, resulting in service exceptions. Optional cap allows identity to pass max value of 20, while other primitives are unchanged.Related Issue
Closes #
Documentation PR
Type of Change
Testing
Manually tested the TUI with
bun run startand interacting with the TUI screen. Also ran the full suite against latest HEAD after rebasing the refactor branch:bun test src/ (590 pass, 0 fail)
bun run typecheck clean
bun run lint:check clean
bun run format:check clean
bun run build
I ran
npm run test:unitandnpm run test:integI ran
npm run typecheckI ran
npm run lintIf I modified
src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.