Skip to content

Update 09 21 - #167

Open
csantanapr wants to merge 2 commits into
aws-samples:mainfrom
csantanapr:update-09-21
Open

Update 09 21#167
csantanapr wants to merge 2 commits into
aws-samples:mainfrom
csantanapr:update-09-21

Conversation

@csantanapr

Copy link
Copy Markdown
Member

Description of changes:

update to gitops-bridge addons

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
@csantanapr
csantanapr requested a review from allamand September 21, 2023 22:31

@allamand allamand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a tool to check on all new versions ?

I had issue with local path not found in the path, seems you rollbacked some of them

valueFiles:
- $values/{{metadata.annotations.addons_repo_basepath}}environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml
- $values/{{metadata.annotations.addons_repo_basepath}}clusters/{{name}}/addons/{{values.addonChart}}/resources/values.yaml
- ../../../../environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you bring back local path ?

valueFiles:
- $values/{{metadata.annotations.addons_repo_basepath}}environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml
- $values/{{metadata.annotations.addons_repo_basepath}}clusters/{{name}}/addons/{{values.addonChart}}/resources/values.yaml
- ../../../../environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same ?

valueFiles:
- $values/{{metadata.annotations.addons_repo_basepath}}environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml
- $values/{{metadata.annotations.addons_repo_basepath}}clusters/{{name}}/addons/{{values.addonChart}}/resources/values.yaml
- ../../../../environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

valueFiles:
- $values/{{metadata.annotations.addons_repo_basepath}}environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml
- $values/{{metadata.annotations.addons_repo_basepath}}clusters/{{name}}/addons/{{values.addonChart}}/resources/values.yaml
- ../../../../environments/{{metadata.labels.environment}}/addons/{{values.addonChart}}/resources/values.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants