updated outputs to include API GW URL. Modified CloudFormation to all… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow for API-GW to work (made ALB params optional by making default values). Changed parameter types for LBSubnets and LambdaSubnets to String, and added Split inside of resource to split the comma delimited string into a List (Required in order to make LBSubnets optional as the original way required a valid Subnet-Id to be passed into the template). Updated S3 bucket to allow for hyphens and letters. Updated code/index.js to explicitly look in the node_modules folder for the axios dependency (Lambda was throwing errors about not being able to find axios).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated outputs to include API GW URL. Modified CloudFormation to allow for API-GW to work (made ALB params optional by making default values). Changed parameter types for LBSubnets and LambdaSubnets to String, and added Split inside of resource to split the comma delimited string into a List (Required in order to make LBSubnets optional as the original way required a valid Subnet-Id to be passed into the template). Updated S3 bucket to allow for hyphens and letters. Updated code/index.js to explicitly look in the node_modules folder for the axios dependency (Lambda was throwing errors about not being able to find axios).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.