-
Notifications
You must be signed in to change notification settings - Fork 785
Improvements for ELB functionality #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om different places
…althy) are suspended while deploying and resume only the ones suspended by the script. Also abort if Launch process is disabled as it will not allow to return and instance from StandBy
- Added notice about suspended processes - Fixed some Markdown style issues - Fixed missing link to documentation
…itrary values. - Removed dependency on bc by using awk instead. - Removed ASG checks from reset_waiter_timeout as it's only considered for ELBs. - Further improved the query string on reset_waiter_timeout function (and tested it working on Ubuntu Trusty)
default50
added a commit
to default50/CodeDeploy_SampleApp_Linux
that referenced
this pull request
Jun 14, 2016
…d deregister_from_elb.sh was not run on ApplicationStop
default50
added a commit
to default50/CodeDeploy_SampleApp_Linux
that referenced
this pull request
Jul 7, 2016
…arification to README.md
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing PRs #40 and #41 from @wjordan I realized that my PR #43 was only fixing issues with ASGs.
I integrated those changes (with some extra tweaks) into this new PR, which is based off a branch of my asg_suspend_processes. So you can consider this superseding all those previous PRs. Adding my previous comments below quoted, for reference.
This are the added changes:
_all_
and_any_
as well as a style fix.bc
by usingawk
instead.reset_waiter_timeout
as it's only considered for ELBs.reset_waiter_timeout
function (and tested it working on Ubuntu Trusty)