feat(tracing): add Subsegment wrapper to prevent exposing Amazon.XRayRecorder.Core.Internal #950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #603
Summary
Changes
This PR creates a wrapper to prevent exposing internal lib
Amazon.XRayRecorder
.libraries/src/AWS.Lambda.Powertools.Tracing/Internal/TracingSubsegment.cs
to place the wrapper;libraries/src/AWS.Lambda.Powertools.Tracing/Tracing.cs
to include the wrapper;User experience
Before the changes, users had to include the reference to
Amazon.XRay.Recorder.Core.Internal.Entities
to use theSubsegment
class. Now, theTracingSubsegment
was created and users can now import them using theAWS.Lambda.Powertools.Tracing.Internal
reference.Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
NO
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.