Update pr action to use v4 for cache and checkout actions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARichman555
force-pushed
the
compile-vpc-id
branch
from
3f56cd2 to
7796a8f
Compare
|
Isn't there a github action that can do this compilation for us? I don't remember having to do this last time I updated this repo. |
|
lgtm, other than bmsiegel's comment |
Collaborator
Author
|
I believe this is supposed to do it, but this did not run when I merged in the last change: https://github.com/aws-pca-k8s-plugin-ops-admin/ec2-github-runner/blob/main/.github/workflows/package.yml. I believe because we hadn't enabled workflows yet since forking this. Ideally, after this it should just work |
Collaborator
Author
|
I guess we could just make the linter workflow changes and it should compile if we want to not manually merge the compiled code |
Signed-off-by: Alex Richman <[email protected]>
ARichman555
force-pushed
the
compile-vpc-id
branch
from
7796a8f to
69d3141
Compare
ARichman555
changed the title
Collaborator
Author
|
Updated the PR to just be the action changes and it should run the action which will compile the code for us |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the pr.yml action to use v4 for the cache and checkout actions. v2 of these actions has been deprecated: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Signed-off-by: Alex Richman [email protected]