generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 28
Add Service and Environment dimensions to EMF metrics when Application Signals is enabled #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
syed-ahsan-ishtiaque
merged 1 commit into
main
from
add-lambda-emf-service-environment-dimensions
Dec 5, 2025
Merged
Add Service and Environment dimensions to EMF metrics when Application Signals is enabled #548
syed-ahsan-ishtiaque
merged 1 commit into
main
from
add-lambda-emf-service-environment-dimensions
Dec 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
reviewed
Dec 4, 2025
...entelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py
Outdated
Show resolved
Hide resolved
wangzlei
reviewed
Dec 4, 2025
...entelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py
Outdated
Show resolved
Hide resolved
wangzlei
reviewed
Dec 4, 2025
...entelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py
Outdated
Show resolved
Hide resolved
607d03e to
3cdbfa7
Compare
wangzlei
reviewed
Dec 4, 2025
...entelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py
Outdated
Show resolved
Hide resolved
eefdb6c to
add1a3c
Compare
wangzlei
reviewed
Dec 5, 2025
...entelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py
Outdated
Show resolved
Hide resolved
add1a3c to
1609459
Compare
…n Signals is enabled When both OTEL_AWS_APPLICATION_SIGNALS_ENABLED and OTEL_AWS_APPLICATION_SIGNALS_EMF_EXPORT_ENABLED are true, inject "Service" and "Environment" dimensions into EMF metrics. - Service: extracted from resource via get_service_attribute(), falls back to "UnknownService" - Environment: extracted from deployment.environment resource attribute, falls back to "lambda:default" - Case-insensitive check prevents overwriting user-set dimensions - Lambda wrapper sets OTEL_AWS_APPLICATION_SIGNALS_EMF_EXPORT_ENABLED=true by default 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1609459 to
02d5cae
Compare
wangzlei
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When both OTEL_AWS_APPLICATION_SIGNALS_ENABLED and
OTEL_AWS_APPLICATION_SIGNALS_EMF_EXPORT_ENABLED are true, inject
"Service" and "Environment" dimensions into EMF metrics.
back to "UnknownService"
falls back to "lambda:default"
by default
Test plan
test_base_emf_exporter.pyis_lambdaparameter intest_console_emf_exporter.pytest_aws_opentelementry_configurator.pyTesting
Lambda Code
CW Metrics
Application Signals Related Metrics
🤖 Generated with Claude Code