Not patch code attributes if the input is not function or method #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vastin
previously approved these changes
Nov 18, 2025
Contributor
|
The contract tests failed and need to be updated because code attribute feature is disabled by default. |
mxiamxia
approved these changes
Nov 19, 2025
wangzlei
added a commit
to wangzlei/aws-otel-python-instrumentation
that referenced
this pull request
Nov 19, 2025
…-observability#538) *Issue #, if available:* When a Starlette user registers an ASGI app via the route registration method, the ADOT Python SDK’s Starlette instrumentation mistakenly treats it as a regular synchronous function. As a result, the patched ASGI app cannot be properly registered in Starlette, preventing Starlette from starting the app. This leads clients to receive 405 Method Not Allowed errors. Since FastMCP registers ASGI apps with Starlette, this bug causes MPC services built with FastMCP to fail to start. *Description of changes:* When Starlette’s route registration method receives a callable that is neither a function nor a method, the ADOT Python SDK leaves it unmodified, allowing the ASGI app to be registered and started correctly. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
wangzlei
added a commit
that referenced
this pull request
Nov 19, 2025
… (#542) *Issue #, if available:* When a Starlette user registers an ASGI app via the route registration method, the ADOT Python SDK’s Starlette instrumentation mistakenly treats it as a regular synchronous function. As a result, the patched ASGI app cannot be properly registered in Starlette, preventing Starlette from starting the app. This leads clients to receive 405 Method Not Allowed errors. Since FastMCP registers ASGI apps with Starlette, this bug causes MPC services built with FastMCP to fail to start. *Description of changes:* When Starlette’s route registration method receives a callable that is neither a function nor a method, the ADOT Python SDK leaves it unmodified, allowing the ASGI app to be registered and started correctly. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When a Starlette user registers an ASGI app via the route registration method, the ADOT Python SDK’s Starlette instrumentation mistakenly treats it as a regular synchronous function. As a result, the patched ASGI app cannot be properly registered in Starlette, preventing Starlette from starting the app. This leads clients to receive 405 Method Not Allowed errors.
Since FastMCP registers ASGI apps with Starlette, this bug causes MPC services built with FastMCP to fail to start.
Description of changes:
The PR contains 2 changes:
OTEL_AWS_EXPERIMENTAL_CODE_ATTRIBUTES=trueBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.