Fix: Unable to run ADOT Python unit tests with latest Tox release #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox 3.27.1 was released on November 14, 2022 — before Python 3.12 (October 2023) and Python 3.13 (October 2024) — and does not officially support either version. This PR resolves the blocking issue caused by using the latest Tox release. Changes: - Updated tox.ini to pass valid VCS requirement strings to pip and avoid shell/INI parsing issues. - Removed stray spaces before '@' in pip VCS requirement specifiers. - Removed unnecessary wrapping quotes so strings are not passed with quote characters. - Escaped the '#' in INI fragments to ensure the tox/INI parser preserves pip fragments (e.g., `#egg=...`). Tested with: ```bash python -m venv .venv source .venv/bin/activate pip install tox tox -e lint tox -e spellcheck tox -e 3.9-test-aws-opentelemetry-distro tox -e 3.10-test-aws-opentelemetry-distro tox -e 3.11-test-aws-opentelemetry-distro tox -e 3.12-test-aws-opentelemetry-distro tox -e 3.13-test-aws-opentelemetry-distro ```
thpierce
reviewed
Oct 27, 2025
thpierce
approved these changes
Oct 28, 2025
lukeina2z
added a commit
to lukeina2z/aws-otel-python-instrumentation
that referenced
this pull request
Oct 29, 2025
…ease (aws-observability#521)" This reverts commit ffa291c, reversing changes made to 533fafd.
lukeina2z
added a commit
that referenced
this pull request
Oct 29, 2025
…ease (#521)" (#523) This reverts commit ffa291c, reversing changes made to 533fafd. *Issue #, if available:* App Signals E2E tests are failing. *Description of changes:* Revert the previous Tox related change. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
lukeina2z
added a commit
to lukeina2z/aws-otel-python-instrumentation
that referenced
this pull request
Oct 30, 2025
…lease (aws-observability#521)" (aws-observability#523) This reverts commit 6ae6225.
lukeina2z
added a commit
that referenced
this pull request
Oct 30, 2025
…lease (#521)" (#523) (#527) This reverts commit 6ae6225. *Issue #, if available:* #521 was reverted to help narrow down the E2E tests failures. Fix: Unable to run ADOT Python unit tests with latest Tox release #521 *Description of changes:* Revert #523 #521 is not the culprit. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
lukeina2z
added a commit
to lukeina2z/aws-otel-python-instrumentation
that referenced
this pull request
Oct 31, 2025
…t Tox release (aws-observability#521)" (aws-observability#523) (aws-observability#527)" This reverts commit 49f8a7a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox 3.27.1 was released on November 14, 2022 — before Python 3.12 (October 2023) and Python 3.13 (October 2024) — and does not officially support either version.
This PR resolves the blocking issue caused by using the latest Tox release 4.30.3.
Changes:
#egg=...).Tested with:
python -m venv .venv source .venv/bin/activate pip install tox tox -e lint tox -e spellcheck tox -e 3.9-test-aws-opentelemetry-distro tox -e 3.10-test-aws-opentelemetry-distro tox -e 3.11-test-aws-opentelemetry-distro tox -e 3.12-test-aws-opentelemetry-distro tox -e 3.13-test-aws-opentelemetry-distroBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.