Skip to content

Conversation

@wangzlei
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ezhang6811 and others added 12 commits July 31, 2025 18:52
This PR prepares the main branch for the next development cycle by
updating the version to 0.12.0.dev0 and updating the image version to be
scanned to the latest released.

This PR should only be merge when release for version v0.12.0 is
success.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
*Issue #, if available:*

*Description of changes:*
This PR modifies the release build workflow to wait for the main build
workflow in the same branch to complete successfully. before proceeding
with the release. If the latest main build run has status `queued` or
`in_progress`, or has completed without the conclusion `success`, the
workflow exits early.

Tested this logic in personal fork with dummy workflows.
failed release workflow example 1 (main build in progress):
https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478717524/job/49644636222
failed release workflow example 2 (main build failed):
https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478713160/job/49644619601
successful release workflow example:
https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478731487

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
…ent Observability (#464)

*Description of changes:*
`Starlette Instrumentor` utilizes the `OpenTelemetryMiddleware`
instrumentation to capture all events generated by
[ASGI](https://asgi.readthedocs.io/en/latest/implementations.html#starlette)
`Request received, Response headers sent (http.response.start), Response
body sent (http.response.body)` which leads to a lot of span noises for
streaming events:
<img width="1149" height="595" alt="image"
src="https://github.com/user-attachments/assets/8076586e-5e09-46cc-ba94-772d81a18824"
/>

Luckily, the upstream `OpenTelemetryMiddleware` provides a configuration
in the constructor to suppress these instrumentations:
https://github.com/open-telemetry/opentelemetry-python-contrib/blob/51da0a766e5d3cbc746189e10c9573163198cfcd/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py#L573

Enabling this for Agent Observability to help filter out noise.
<img width="1685" height="481" alt="image"
src="https://github.com/user-attachments/assets/e639969f-af2a-4559-bec7-c84962a243ad"
/>

Related issue for removing the need for this patch in the long term,
using the proposed `OTEL_PYTHON_STARLETTE_EXCLUDED_SPANS` environment
variable:

open-telemetry/opentelemetry-python-contrib#3725

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
@wangzlei wangzlei requested a review from a team as a code owner September 15, 2025 23:42
@wangzlei wangzlei merged commit 1fb67a7 into release/v0.12.x Sep 15, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants