generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 29
Merge main to release/v0.12.x for v0.12.1 releasing #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prepares the main branch for the next development cycle by updating the version to 0.12.0.dev0 and updating the image version to be scanned to the latest released. This PR should only be merge when release for version v0.12.0 is success. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
*Issue #, if available:* *Description of changes:* This PR modifies the release build workflow to wait for the main build workflow in the same branch to complete successfully. before proceeding with the release. If the latest main build run has status `queued` or `in_progress`, or has completed without the conclusion `success`, the workflow exits early. Tested this logic in personal fork with dummy workflows. failed release workflow example 1 (main build in progress): https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478717524/job/49644636222 failed release workflow example 2 (main build failed): https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478713160/job/49644619601 successful release workflow example: https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/17478731487 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
…ent Observability (#464) *Description of changes:* `Starlette Instrumentor` utilizes the `OpenTelemetryMiddleware` instrumentation to capture all events generated by [ASGI](https://asgi.readthedocs.io/en/latest/implementations.html#starlette) `Request received, Response headers sent (http.response.start), Response body sent (http.response.body)` which leads to a lot of span noises for streaming events: <img width="1149" height="595" alt="image" src="https://github.com/user-attachments/assets/8076586e-5e09-46cc-ba94-772d81a18824" /> Luckily, the upstream `OpenTelemetryMiddleware` provides a configuration in the constructor to suppress these instrumentations: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/51da0a766e5d3cbc746189e10c9573163198cfcd/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py#L573 Enabling this for Agent Observability to help filter out noise. <img width="1685" height="481" alt="image" src="https://github.com/user-attachments/assets/e639969f-af2a-4559-bec7-c84962a243ad" /> Related issue for removing the need for this patch in the long term, using the proposed `OTEL_PYTHON_STARLETTE_EXCLUDED_SPANS` environment variable: open-telemetry/opentelemetry-python-contrib#3725 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
liustve
approved these changes
Sep 15, 2025
mxiamxia
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.