LLO Handler Setup w/ Lazy Initialization #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
force-pushed
the
setup-llo-handler
branch
from
8f2777d to
9e4c375
Compare
yiyuan-he
force-pushed
the
setup-llo-handler
branch
from
9e4c375 to
2a9672c
Compare
mxiamxia
reviewed
Jun 20, 2025
| try: | ||
| self._logger_provider = get_logger_provider() | ||
| except Exception: # pylint: disable=broad-exception-caught | ||
| return False |
There was a problem hiding this comment.
Please add a debug log when the logger provider can't be retrieved. this will help us diagnose cases where GenAI events don't appear because of it."
There was a problem hiding this comment.
Makes sense - added a debug log here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Sets up our new
LLOHandlerwhich will be used extract input/output prompt data from spans and send them to the logs pipeline.We choose lazy loading because it solves an initialization order issue where
OTLPAwsSpanExporterinitialization may fail whenAGENT_OBSERVABILITY_ENABLED=truebecause the logger provider is not ready yet.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.