Skip to content

feat: Support Gen AI attributes for Amazon Nova foundational model #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxiamxia merged 10 commits into from
Dec 17, 2024
Merged

feat: Support Gen AI attributes for Amazon Nova foundational model #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a89bf6
support of amazon nova model
liustve Dec 11, 2024
d56d681
support for amazon nova model
liustve Dec 12, 2024
78cd83b
revert bedrock testing on simple client server app
liustve Dec 12, 2024
3448289
formatting fix
liustve Dec 12, 2024
6fe1ca7
formatting
liustve Dec 12, 2024
fcffa19
linting fix
liustve Dec 12, 2024
1aa4a90
ignore too many branches linting
liustve Dec 12, 2024
6dc5ac7
linting fix
liustve Dec 12, 2024
aa322b8
Merge branch 'main' into genai_nova
liustve Dec 16, 2024
c99a529
Merge branch 'aws-observability:main' into genai_nova
liustve Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_bedrock_patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,8 @@ def extract_attributes(self, attributes: _AttributeMapT):

if "amazon.titan" in model_id:
self._extract_titan_attributes(attributes, request_body)
if "amazon.nova" in model_id:
self._extract_nova_attributes(attributes, request_body)
elif "anthropic.claude" in model_id:
self._extract_claude_attributes(attributes, request_body)
elif "meta.llama" in model_id:
Expand All @@ -288,6 +290,12 @@ def _extract_titan_attributes(self, attributes, request_body):
self._set_if_not_none(attributes, GEN_AI_REQUEST_TOP_P, config.get("topP"))
self._set_if_not_none(attributes, GEN_AI_REQUEST_MAX_TOKENS, config.get("maxTokenCount"))

def _extract_nova_attributes(self, attributes, request_body):
config = request_body.get("inferenceConfig", {})
self._set_if_not_none(attributes, GEN_AI_REQUEST_TEMPERATURE, config.get("temperature"))
self._set_if_not_none(attributes, GEN_AI_REQUEST_TOP_P, config.get("top_p"))
self._set_if_not_none(attributes, GEN_AI_REQUEST_MAX_TOKENS, config.get("max_new_tokens"))

def _extract_claude_attributes(self, attributes, request_body):
self._set_if_not_none(attributes, GEN_AI_REQUEST_MAX_TOKENS, request_body.get("max_tokens"))
self._set_if_not_none(attributes, GEN_AI_REQUEST_TEMPERATURE, request_body.get("temperature"))
Expand Down Expand Up @@ -324,6 +332,7 @@ def _set_if_not_none(attributes, key, value):
if value is not None:
attributes[key] = value

# pylint: disable=too-many-branches
def on_success(self, span: Span, result: Dict[str, Any]):
model_id = self._call_context.params.get(_MODEL_ID)

Expand All @@ -342,6 +351,8 @@ def on_success(self, span: Span, result: Dict[str, Any]):
response_body = json.loads(telemetry_content.decode("utf-8"))
if "amazon.titan" in model_id:
self._handle_amazon_titan_response(span, response_body)
if "amazon.nova" in model_id:
self._handle_amazon_nova_response(span, response_body)
elif "anthropic.claude" in model_id:
self._handle_anthropic_claude_response(span, response_body)
elif "meta.llama" in model_id:
Expand Down Expand Up @@ -375,6 +386,17 @@ def _handle_amazon_titan_response(self, span: Span, response_body: Dict[str, Any
if "completionReason" in result:
span.set_attribute(GEN_AI_RESPONSE_FINISH_REASONS, [result["completionReason"]])

# pylint: disable=no-self-use
def _handle_amazon_nova_response(self, span: Span, response_body: Dict[str, Any]):
if "usage" in response_body:
usage = response_body["usage"]
if "inputTokens" in usage:
span.set_attribute(GEN_AI_USAGE_INPUT_TOKENS, usage["inputTokens"])
if "outputTokens" in usage:
span.set_attribute(GEN_AI_USAGE_OUTPUT_TOKENS, usage["outputTokens"])
if "stopReason" in response_body:
span.set_attribute(GEN_AI_RESPONSE_FINISH_REASONS, [response_body["stopReason"]])

# pylint: disable=no-self-use
def _handle_anthropic_claude_response(self, span: Span, response_body: Dict[str, Any]):
if "usage" in response_body:
Expand Down
Loading
Loading