feat: add ability to configure tes error cache expire time #1751
+133
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Binary incompatibility detected for commit 732599d. com.aws.greengrass.tes.CredentialRequestHandler is binary incompatible and is source incompatible because of FIELD_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 732599d |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 732599d |
saranyailla
reviewed
Nov 21, 2025
|
|
||
| public static final String CLOUD_4XX_ERROR_CACHE_TOPIC = "cloud4xxErrorCacheInSec"; | ||
| public static final String CLOUD_5XX_ERROR_CACHE_TOPIC = "cloud5xxErrorCacheInSec"; | ||
| public static final String UNKNOWN_ERROR_CACHE_TOPIC = "unknownErrorCacheInSec"; |
Member
There was a problem hiding this comment.
Nit: Move these to TES class file and rename them to reflect the configuration topics.
The configuration topic names are too implementation specific. These expiration times are when TES will retry fetching credentials again, right? Can we instead call them as error4xxCredentialRetryInSec?
Member
Author
There was a problem hiding this comment.
I moved them to TES class and renamed them
saranyailla
reviewed
Nov 24, 2025
| this.credentialRequestHandler = credentialRequestHandler; | ||
|
|
||
| cloud4xxErrorCache = validateCacheConfig(Coerce.toInt(config.lookup( | ||
| CONFIGURATION_CONFIG_KEY, CLOUD_4XX_ERROR_CACHE_TOPIC).dflt( |
Member
There was a problem hiding this comment.
Let's replace this with findOrDefault?
lookup and dflt create configuration nodes (topics). We don't always need to write the default values to config file for optimization reasons (such as having less no of writes and callback events, and config file remains smaller without losing information).
saranyailla
reviewed
Nov 24, 2025
| logger.atDebug("tes-cache-config-change").kv("node", node).kv("why", why).log(); | ||
|
|
||
| int newCloud4xxErrorCache = validateCacheConfig(Coerce.toInt(config.lookup( | ||
| CONFIGURATION_CONFIG_KEY, CLOUD_4XX_ERROR_CACHE_TOPIC).dflt( |
Member
There was a problem hiding this comment.
Same comment as above to not use dflt as this will trigger the subscribe callback again with the updated value when the node value is null.
saranyailla
reviewed
Nov 24, 2025
| private int validateCacheConfig(int newCacheValue, int oldCacheValue) { | ||
| if (newCacheValue < MINIMUM_ERROR_CACHE_IN_SEC) { | ||
| logger.atError().log("Error cache value must be at least {}", MINIMUM_ERROR_CACHE_IN_SEC); | ||
| return oldCacheValue; |
Member
There was a problem hiding this comment.
Instead of the old value, we'd want to use default value for each of these or the minimum error cache value. We don't know if the old value itself is valid or not.
saranyailla
reviewed
Nov 24, 2025
| credentialRequestHandler.configureCacheSettings(cloud4xxErrorCache, cloud5xxErrorCache, unknownErrorCache); | ||
|
|
||
| // Subscribe to cache configuration changes | ||
| config.subscribe((why, node) -> { |
Member
There was a problem hiding this comment.
This should be combined with the existing subscribe callback for port changes as it will otherwise create two callback executions when port and error cache config are updated at the same time .
If both port and error cache config are updated at the same time, it is enough to restart TES once.
… avoid multiple restarts
rauthsuj
force-pushed
the
tes-configure
branch
from
7b3fd9b to
732599d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add ability for users to configure TES error cache expire time
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.