Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 23, 2025

Update to ACK runtime v0.54.1, code-generator v0.54.0



NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.1.3

Once this PR is merged, release v1.1.3 will be automatically created for opensearchservice-controller

Please close this PR, if you do not want the new patch release for opensearchservice-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building opensearchservice-controller ====
Copying common custom resource definitions into opensearchservice
Building Kubernetes API objects for opensearchservice
Generating deepcopy code for opensearchservice
Generating custom resource definitions for opensearchservice
Building service controller for opensearchservice
Running GO mod tidy
Generating RBAC manifests for opensearchservice
Running gofmt against generated code for opensearchservice
Updating additional GitHub repository maintenance files
==== building opensearchservice-controller release artifacts ====
Building release artifacts for opensearchservice-v1.1.3
Generating common custom resource definitions
Generating custom resource definitions for opensearchservice
Generating RBAC manifests for opensearchservice

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 23, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm November 23, 2025 09:19

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 11 days ago

To fix the problem, add a permissions block at the top-level of the workflow file (i.e., as a peer to name, on, and jobs). For workflows that trigger on a push and only call a reusable workflow without directly running steps using the token, the minimum safe permissions are contents: read. You can later increase permissions only if workflow requirements demand it. This should be done in .github/workflows/postsubmit.yaml, above or directly below the on: declaration, to ensure the minimal access for the GITHUB_TOKEN.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -5,6 +5,9 @@
     branches:
       - main
 
+permissions:
+  contents: read
+
 jobs:
   call-hydrate-go-proxy:
     uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main
EOF
@@ -5,6 +5,9 @@
branches:
- main

permissions:
contents: read

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
opensearchservice-verify-code-gen 1641a7c link false /test opensearchservice-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link

knottnt commented Nov 29, 2025

/close

@ack-prow ack-prow bot closed this Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@knottnt: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants