-
Notifications
You must be signed in to change notification settings - Fork 12
Update to ACK runtime v0.54.1, code-generator v0.54.0
#58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ack-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix the problem, add an explicit permissions key to the root of the workflow or to the job definition in .github/workflows/postsubmit.yaml. As a delegator workflow, the minimal starting point is to use the most restrictive option, which is permissions: {} at the root level. This ensures the GITHUB_TOKEN has no permissions (unless the called workflow/job needs more; then you would grant only what's required). The recommended least-privilege block for delegator workflows is:
permissions: {}This should be added after the name: and before on: (or before jobs:), applying to all jobs by default.
-
Copy modified line R2
| @@ -1,4 +1,5 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: {} | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update to ACK runtime
v0.54.1, code-generatorv0.54.0v0.54.0release notesv0.54.1release notesNOTE:
This PR increments the release version of service controller from
v1.3.1tov1.3.2Once this PR is merged, release
v1.3.2will be automatically created forcloudwatch-controllerPlease close this PR, if you do not want the new patch release for
cloudwatch-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.